Make the Search API module compatible with PHP 8.0.

CommentFileSizeAuthor
#4 search_api-n3208036-4.patch702 bytesdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The tests for Metatag use Search API and ran into the following:

exception: [Warning] Line 3280 of sites/all/modules/search_api/search_api.module:
Trying to access array offset on value of type null
fail: [PHP Deprecated] Line 3404 of sites/all/modules/search_api/search_api.module:
 Required parameter $context follows optional parameter $drush

The first one might be because of something in Metatag (haven't dug into it yet), but the second one is definitely a Search API thing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +PHP 8.0, +DrupalFest2021
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new search_api-n3208036-4.patch702 bytes

This fixes the second one, I need to look at other bugs in the Metatag tests before I can work on the other one.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Needs review » Reviewed & tested by the community

$drush parameter must be passed anyway, so it looks good

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Yes, looks great, thanks a lot!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

stefanos.petrakis’s picture

stefanos.petrakis
Primary language English
Location Biel, Switzerland
commented
Parent issue: #3208034: PHP 7.4 and 8.0 compatibility for Entity Translation »
Related issues: +#3208034: PHP 7.4 and 8.0 compatibility for Entity Translation

Linking as related (not parent).