Closed (fixed)
Project:
Entity Translation
Version:
7.x-1.x-dev
Component:
Base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
9 Apr 2021 at 15:19 UTC
Updated:
9 Nov 2021 at 18:29 UTC
Jump to comment: Most recent, Most recent file
Show commands
changes
Comments
Comment #2
damienmckennaThe Metatag tests ran into the following error in entity_translation:
Comment #3
damienmckennaComment #4
damienmckennaThis updates EntityTranslationDefaultHandler::translationTabSort() so it returns the correct arguments for usort().
Comment #5
stefanos.petrakisHi @DamienMcKenna, thanks for bringing this up.
The patch in #4 is packing a bit of change with it, this method has been working under the hood with just 0s and 1s so far, no negatives.
I was wondering if wrapping the existing code inside e.g.
intval()would be sufficient while solving the PHP8 compatibility issue for this part of the code.Does that mean the rest of the codebase is PHP8 compatible, did you by any chance check that too?
Comment #6
damienmckennaI didn't check anything else, I just ran into this one specific thing while testing Metatag. The PHP 8 tests show a few other problems, so I suspect there might need to be some more work done.
Comment #8
stefanos.petrakisAlmost there, this should fix the reported fails for 7.4 and 8.0
Comment #9
stefanos.petrakisHi @DamienMcKenna, this needed a couple of different things to get it to work.
Any chance you could review the current state?
Comment #10
stefanos.petrakisComment #11
joseph.olstadTests are looking very green!
i18n now has the fixes we need here.
Comment #12
stefanos.petrakisIt would be great to have some review/feedback for this one, it would trigger a new minor release, offering PHP 7.4 and 8.0 support.
Comment #13
joseph.olstadI have been using php 7.4 on at least one project recently and using entity_translation, no issues however its not using workbench moderation. I do have a good recipe for workbench moderation with entity_translation , however those projects aren't using php 7.4 yet.
I haven't yet tried php 8.0 yet but probably soon
Comment #15
stefanos.petrakisI am going to commit this, got the testbot to support my code changes here.
I find that extending compatibility support to 8.0 is must at this point in time for users of ET.
Comment #17
joseph.olstadHi @stephanos, please make sure this goes into a tagged release soon, upstream core is fixed, they just fixed the last known php 7.4 related core bug and it also helps PHP 8.0
now several of my contrib projects are passing all PHP 8.0 tests with the latest core update