I was trying to make these layouts available on a site with Layout Builder enabled, but they don't have the classes that tool needs to work correctly. The layouts can be added to a page but don't get the region styling and items cannot be dragged between regions.

CommentFileSizeAuthor
#7 2990981-radix_layouts_layout_builder-7.patch64.52 KBhart0554
#6 Screen Shot 2018-09-15 at 12.04.39 AM.png954.51 KBimalabya
#2 2990981-radix_layouts_layout_builder-2.patch61.24 KBhart0554

Comments

hart0554 created an issue. See original summary.

hart0554’s picture

hart0554 commented
StatusFileSize
new 2990981-radix_layouts_layout_builder-2.patch61.24 KB

I updated the templates to write classes into the markup in a way that is more consistent with the layouts included with layout_discovery, as well as making use of the region_attributes variable that layout_discovery provides.

shadcn’s picture

shadcn commented
Assigned: Unassigned » shadcn

Woah thanks. I'll take a look at it this weekend.

amme’s picture

amme commented
Status: Active » Needs review
shadcn’s picture

shadcn commented
Status: Needs review » Needs work

@hart0554 the patch does not apply anymore? Can you reroll against the 8.x-4.x branch please? Thank you.

imalabya’s picture

imalabya
Primary language English
Location Bangalore
commented
Status: Needs work » Needs review
StatusFileSize
new Screen Shot 2018-09-15 at 12.04.39 AM.png954.51 KB

The patch applies cleanly to the 8.x-4.x branch.

hart0554’s picture

hart0554 commented
StatusFileSize
new 2990981-radix_layouts_layout_builder-7.patch64.52 KB

It's applying for me as well. That said, in checking this I realized I missed two layouts (Brenham Flipped and Burr Flipped) in the initial patch. Here's an updated one that accounts for all the layouts.

playful’s picture

playful commented

@ hart0554

Thank you for this patch! It worked perfectly for me.

This module hasn't had a release since May 2017. Can we get this module updated and released to include this patch?

shadcn’s picture

shadcn commented

Yes. Sure. I'll tag and create a new release today.

  • arshadcn committed c6dbd54 on 8.x-4.x authored by hart0554 
    Issue #2990981 by hart0554, imalabya: Radix layouts not compatible with...
shadcn’s picture

shadcn commented
Status: Needs review » Fixed

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.