Problem/Motivation

The CI pipeline currently isn't green. I think it would be great, if that could be accomplished.

Furthermore we might set 

phpcs:
  allow_failure: false

phpstan:
  allow_failure: false

cspell:
  allow_failure: false

etc. where it makes sense, to that it's never allowed to make things worse again?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork radix-3614968

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

kieran.cott made their first commit to this issue’s fork.

kieran.cott opened merge request !182

kieran.cott’s picture

kieran.cott
Location Manila 🇵🇭
commented
Assigned: Unassigned » kieran.cott
kieran.cott’s picture

kieran.cott
Location Manila 🇵🇭
commented
Assigned: kieran.cott » Unassigned
Status: Active » Needs review

Implemented the usual MR pipeline checks in .gitlab-ci.yml - made necessary changes to get them passing.
Also added a bit of PHPUnit regression coverage.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@kieran.cott thank you, LGTM! Just left one minor question.

RTBC+1

kieran.cott opened merge request !183

doxigo made their first commit to this issue’s fork.

  • doxigo committed 768263df on 6.0.x 
    Issue #3614968: Gate the pipeline on the validate jobs and fix what that...
doxigo’s picture

doxigo commented
Status: Needs review » Fixed

Thanks guys, this is merged with a follow-up push to have the validate jobs enforced

Every validate job (phpcs, phpstan, cspell, stylelint, eslint) is allow_failure: true by default, so they reported yellow and never gated a merge.

Not sure if that's a good thing or not, might disable it but for now merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.