Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.On a high traffic site, with either below two scenario:
1. live storage
2. deferred storage and multi-threaded cron
The energy saved in field gets set to zero now and then.
The root cause is that in updateEnergy method, the field sql storage performs a delete/insert rather than an update action, so there is chance that between the delete and insert action, another updateEnergy method would get an empty field data, and with code http://cgit.drupalcode.org/radioactivity/tree/radioactivity.module?id=14... , it will be given to a zero initial value.
Proposed Solution, use Drupal Queue for energy updating instead of a foreach in cron to ensure the order of the incidents processing.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 0003-Use-Drupal-bultin-lock-system-instead.patch | 2.39 KB | weynhamz |
| #4 | 0002-Lock-the-updating-to-prevent-race-condition.patch | 2.27 KB | weynhamz |
| #4 | 0001-Use-Drupal-Queue-to-process-incident.patch | 4.9 KB | weynhamz |
Comments
Comment #2
weynhamzComment #3
weynhamzComment #4
weynhamzOK,
Fixed the problem by following patches.
Patch 0001 Use Drupal Queue to update the energy, so that incident is guaranteed to be processed.
Patch 0002 Add a lock through variable system on updating the energy, this commit is obsolete, just keep it for historical purpose. The primary reason is that it does more than a lock, it also records whether the field is initiated, but it turns out on a decay profile, the field will always gets deleted, so it is useless. Also, use Variable system for locking could cause serous performance problems.
Patch 0003 Use Drupal builtin lock system, and it works.