patch for token support in quiz and question feedback

CommentFileSizeAuthor
#11 token_support_in_quiz-2485785-11.patch6.73 KBdjdevin
#9 quiz_tokens_updated2.patch2.85 KBkyoder
#6 quiz_tokens_updated.patch2.81 KBkyoder
quiz_tokens.patch2.41 KBkyoder

Comments

rodgey’s picture

rodgey commented

This is great!

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
Version: 7.x-5.0-alpha9 » 7.x-5.x-dev
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, quiz_tokens.patch, failed testing.

Status: Needs work » Needs review

djdevin queued quiz_tokens.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, quiz_tokens.patch, failed testing.

kyoder’s picture

kyoder commented
StatusFileSize
new quiz_tokens_updated.patch2.81 KB

updated patch for notices

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: quiz_tokens_updated.patch, failed testing.

kyoder’s picture

kyoder commented
StatusFileSize
new quiz_tokens_updated2.patch2.85 KB

updated patch to account for test case that I can't reproduce where nid is not in quiz report form

djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new token_support_in_quiz-2485785-11.patch6.73 KB

Made some changes to ensure check_markup gets called only once, after the tokens have been processed.

Additionally had to clean up _quiz_get_summary_text().

  • djdevin committed ddf14ec on 7.x-5.x authored by kyoder 
    Issue #2485785 by kyoder, djdevin: token support in quiz and question...
djdevin’s picture

djdevin
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.