Problem/Motivation
I encountered an issue that I wanted to upgrade a site to the newest 4.x version. In #3609965. As part of the commit hook_update_last_removed was introduced: https://git.drupalcode.org/project/quicktabs/-/blob/4.0.x/quicktabs.inst...
This basically blocks the upgrade for sites, that haven't ran that update hook.
The installed version of the /Quick Tabs/ module is too old to update. Update
to an intermediate version first (last removed version: 103001, installed
version: 8000).
But since it is indicating that the update hook was obsolete using hook_update_last_removed is a problem. Because it not only tells that an update hook was removed, but it also signalizes Drupal that you cannot upgrade to 4.3.1, if that particular update hook hasn't ran.
And that's a problem for all sites that that trying to upgrade from for example 4.0.1 or lower (where the update hook hasn't existed) to 4.3.1.
But in our case it does not seem to matter if the update hook ran, because js_cookie is not required anymore.
Currently I'm working around it pretending that the site has seen that update hook.
drush php:eval "\Drupal::service('update.update_hook_registry')->setInstalledVersion('quicktabs', 103001);"
Steps to reproduce
Proposed resolution
Remove the quicktabs_update_last_removed hook.
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork quicktabs-3621785
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
szeidlerComment #4
szeidlerComment #5
joelpittetHmm, the purpose of that function is to show that update function doesn't exist anymore... What version were you coming from in the upgrade?
Comment #6
jonsimonsen commentedThe sites where we've observed issues were on this version previously https://www.drupal.org/project/quicktabs/releases/8.x-3.0-alpha7
Those sites were using the oldest version of a distribution we're using. I'm not aware of the issues on any site that was already on 4.x, but that does not necessarily mean that older versions of 4 will work. We usually keep modules auto updated for patch- and minor versions.
Comment #7
joelpittetI looked a bit harder and see where you're coming from thanks you 2, I have committed that.