Problem/Motivation

Autologout recently dropped js_cookie and was asked to look into if we could too. Lets see :)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork quicktabs-3609965

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave opened merge request !69

joelpittet made their first commit to this issue’s fork.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
Parent issue: » #3609965: Replace js_cookie with localStorage for tab memory
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Parent issue: #3609965: Replace js_cookie with localStorage for tab memory » #2996076: Direct Link to a Quick Tab

Referencing the localStorage fix issue

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Credited Marcos Hollanda (mabho) as that is where the localStorage changes came from in #2996076: Direct Link to a Quick Tab

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Biggest difference here is that localStorage lives longer than the cookies did... those were session cookies, they only lasted while the browser was open. Now the last clicked tab "survives" a restart, and old cookies just get ignored.

The huge benefit is we get the same feature without the module dependency or cache-busting cookies! Nothing server-side ever read that cookie, it was just riding along on every request breaking Varnish/CDN caching for anonymous users.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

This looks great!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Sweet, let's get this in :) Merge 🚂

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Title: Look into dropping js_cookie » Replace js_cookie with localStorage for tab memory

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.