The below comment can be acted upon as the issue is fixed.

/src/Plugin/TabType/ViewContent.php


   // Set additional cache keys that depend on the arguments provided for this
    // view.
    // Until this is fixed in core:
    // https://www.drupal.org/project/drupal/issues/2823914
   $render['#cache']['keys'] = array_merge($render['#cache']['keys'], $args);

Issue fork quicktabs-3494835

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anish.a created an issue. See original summary.

kul.pratap’s picture

kul.pratap commented
Assigned: Unassigned » kul.pratap

kul.pratap opened merge request !30

kul.pratap’s picture

kul.pratap commented
Status: Active » Needs review
kul.pratap’s picture

kul.pratap commented
Assigned: kul.pratap » Unassigned
anish.a’s picture

anish.a commented
Status: Needs review » Needs work

You just removed that comment!

What was the context for the comment? What change was needed?

anish.a’s picture

anish.a commented
Related issues: +#2935570: Cached views tabs with different arguments

Adding the reference issue.

anish.a’s picture

anish.a commented

From what I read, the code can be removed. Let me reproduce the issue on Drupal 9.0.x.

kul.pratap’s picture

kul.pratap commented

@anish.a Should i remove the code below the comment because the reference issue is fixed.

anish.a’s picture

anish.a commented
Status: Needs work » Needs review

Removed unwanted code. Tests are passing.

divyansh.gupta’s picture

divyansh.gupta commented
Status: Needs review » Reviewed & tested by the community

Since the referenced issue is fixed and the changes looks good to me and working as expected, also the module is working fine after this fix.
thus moving it to RTBC

smustgrave closed merge request !30

  • smustgrave committed 10e1df95 on 4.0.x 
    Issue #3494835 by anish.a, kul.pratap: Additional Cache keys - Modify...
smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Fixed
smustgrave’s picture

smustgrave commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.