various improvements and fixes

The patched module can be downloaded from here:

EDIT: download location removed, use the latest release

@panji: no, it's not (yet). If you would like to test the patch you can (apply the patch to the latest dev version or) download the patched version from my site..

OK, the first patch
This is PHPdoc and code style fix only, no functional changes.

Please commit, because I can not continue rolling patches without this. Thanks.

this patch is
04. new: better functions to list enabled views and view displays

please commit the previous patch in #9 before this, otherwise I'll have to reroll this patch. Thanks..

a) this patch uses $form_state['clicked_button'] in validation and submit handler to determine the clicked button
b) php notice fix: adds validation to check at least one tab is created

please commit patch #9 and #10 first

this patch does this: #338021: quick tab edit link is on wrong place
I rather made the patch here, because I fear the commit sequence will be mixed, and I'll have to reroll all my patches..

this patch does not depends on previous patches, commit anytime

this patch improves the theme_quicktabs_tabs() function

a) fix php notice and code style
b) add first and last class (note: $index and $i does not have to be equal. This change is not included in my downloadable package (yet), and I think that is why my ajax views does not work inside ajax tabs)
c) removes views module warning (it can't be displayed here, not enough space)
d) uses the drupal_attributes() function

please commit this patch after #12

a) this patch add missing file parameters in hook_theme
b) code style and translation string fixes in hook_menu

no more possible patches for now..

I have made the noted changes #12 in my release on my site and also changed the version string, so people using my release are always warned that they are not using the recommended version..
Now the ajax views inside ajax quicktabs works, but only if the view is on the first tab and there are no other views on the page. Will try to investigate it later with a new issue after this one is fixed..

can you try to delete the theme cache?

I tried the CVS version + patch#13 on a fresh drupal6-dev install and I do not see the that warning..

If you can find the problem then you can move the quicktabs_quicktabs_tabstyles() function from the admin.inc file to the .module file. Hook implementations should be in the .module file. I can not make a proper patch for that now..

this patch creates a %quicktabs wildcard (replaces 3 db queries with 1)

menu rebuild is required, which can be done by visiting admin/build/modules and clicking on the 'Save configuration' button.

this patch moves some code from quicktabs_block() function into new functions: quicktabs_render() and quicktabs_ajax_render()

this will allow to create quicktabs with some php code, without using the blocks functionality or without storing them into db (for non ajax quictabs)

please fix the indentation in the new functions after applying the patch (I did not fix that for the reason to have the patch small and reviewable)

this patch fixes postgresql db insert

please commit after #31

this patch fixes php notices in qt_more_tabs_submit() and qt_remove_tab_submit()

this patch creates a new function quicktabs_render_tabpage() for general tabpage rendering, which opens the possibility to dynamically create tabpages, and to have one theme function for the tabpages later. The code is moved from the functions quicktabs_render() and quicktabs_ajax_render().

and also this patch adds a quicktabs_ajax_block() function and quicktabs/ajax/block menu callback, which is a preparation (for the next larger patch) to have all tab types (node, block, view) for ajax and non ajax quicktabs..

and the patch

this patch
1. removes a comment and an unused variable from quicktabs_settings_submit()
2. small code style changes and php notice fixes

this patch
1. unifies the admin interface for non ajax and ajax quicktabs
2. changes the format how tabpages are stored + update from the old format (run update.php)
3. fixes some php notices

Thanks, I will do that..
can I finish the other problems mentioned in this issue, or would you like to discuss every change I would like to do in the module?

#39 committed

http://drupal.org/cvs?commit=156676

1. last bnid value fixed
2. using the function request_uri() instead $_SERVER['REQUEST_URI']

http://drupal.org/cvs?commit=156681

1. fixed the menu path structure. The breadcrumb and local tasks are displayed correctly now.
2. unified the 'add' and 'edit' quicktabs functions

don't forget to rebuild the menu..

Thanks again Katherine. I definitely do not plan anything on the scale of this issue, and I will ask you to review every larger feature request before I would commit it.

http://drupal.org/cvs?commit=156697

1. fixed views block in quicktab. the views blocks have - (hyphen) in the block id, so I simply changed the ajax quicktab to use 2 --
2. fixed two php notices

the update should be fine from the QT 6.x-1.x (and beta) and 6.x-2.x versions (just run update.php and your blocks should be updated), the only problem is when you used my version from my site (there is no update for that, and I do not plan to make). If you could test the update, that would be a help. If there are remaining problems, I could still fix it and make it easier for others..

@panji: Please create new issues for the the remaining 3. I would like to fix those, but it is outside of this issue. Thanks..

http://drupal.org/cvs?commit=156803

1. node selection changed to inserting node ID into textbox (views uses the same method) instead of selecting it from dropdown
2. teaser and hide title settings for node

http://drupal.org/cvs?commit=156846

the admin form was messed up if the form validation fails, the js and css files have to be added in the theme function..

http://drupal.org/cvs?commit=156850

the permissions changed
only 'administer quicktabs' permission is required to add, edit, delete, clone quicktabs.

menu rebuild is necessary

Index: includes/admin.inc
===================================================================
RCS file: /cvs/drupal-contrib/contributions/modules/quicktabs/includes/Attic/admin.inc,v
retrieving revision 1.1.2.20
diff -u -p -r1.1.2.20 admin.inc
--- includes/admin.inc	4 Dec 2008 17:08:15 -0000	1.1.2.20
+++ includes/admin.inc	4 Dec 2008 17:09:08 -0000
@@ -426,7 +426,7 @@ function quicktabs_form_submit($form, &$
       quicktabs_createblock($quicktabs);
       drupal_set_message(t('Your Quick Tabs block has been created and can now be enabled.'));
     }
-    drupal_goto('admin/build/quicktabs');
+    $form_state['redirect'] = 'admin/build/quicktabs';
   }
 }

@Katherine: this patch does not work. I would like to change the drupal_goto() to redirect but it sometimes fails, and I do not understand why. Maybe you could help me fix this.

if I just click save, then it works fine
but if I click add tab->save->(validation fail) fill title->save I will be redirected to quictabs/ahah where json data is displayed

@@ -373,7 +373,7 @@ function quicktabs_ahah() {
   $args = $form['#parameters'];
   $form_id = array_shift($args);
   $form['#post'] = $_POST;
-  $form['#redirect'] = FALSE;
+  //$form['#redirect'] = FALSE;
   $form['#programmed'] = FALSE;
   $form_state['post'] = $_POST;
   drupal_process_form($form_id, $form, $form_state);

if I remove the $form['#redirect'] from quicktabs_ahah() it seems working. Is it ok to remove it?

I will not make the style selection option in this issue, as it is not a perfect solution yet.
it will be done in #275232: Different styling for different QTabs

http://drupal.org/cvs?commit=157382

style settings cleanup:
fixed invalid XHTML on admin/settings/quicktabs
the quicktabs preview changed from hardcoded to quicktabs_render() function
theme function prepared for the different style per QTabs functionality

you need to reset your default style and clear the theme cache..

addition to #55

I can display json data with the current code also.

click add tab->click save->(validation fail, but just leave it like that)->click save again
results in a redirect to quictabs/ahah where json data is displayed

The remaining issue is summarized here:
#350102: Submit of a form that has been loaded with ajax posts to the ajax callback URL