Problem/Motivation

When email has reached maximum amount of retry threshold it will be deleted from system and will be lost.
As administrator / moderator I don't want to lose emails that have not been send because of mail server downtime.

Proposed resolution

Add ability to send emails constantly until they will not been send od deleted manually from queue.

User interface changes

ToBeDescribed

CommentFileSizeAuthor
#6 queue_mail-threshold_unlimited-3155823-6.patch6.12 KBsinn
#5 queue_mail-threshold_unlimited-3155823-5.patch1.3 KBkyberman
#2 3155823-send-email-constantly-1.patch2.29 KBandriyun

Comments

andriyun created an issue. See original summary.

andriyun’s picture

andriyun commented
Status: Active » Needs review
StatusFileSize
new 3155823-send-email-constantly-1.patch2.29 KB

Please check suggested patch

sinn’s picture

sinn commented

Thank you @andriyun for the proposal.

Patch looks good but let's allow just one setting to manage threshold limit. "threshold" value can be set "-1" for unlimited case. Such option can be defined in the description of the field "Queue retry threshold" or option "Limited"/"Unlimited" can be set as first step. See "cardinality" widget implementation in the `core/modules/field_ui/src/Form/FieldStorageConfigEditForm.php`. Also would be nice to have test for it.

sinn’s picture

sinn commented
Status: Needs review » Needs work
kyberman’s picture

kyberman
Location Czech Rep. 🇨🇿
commented
Status: Needs work » Needs review
StatusFileSize
new queue_mail-threshold_unlimited-3155823-5.patch1.3 KB

Hi, I like the single field idea, so I simplified that a little bit more:
- appended "Leave empty for unlimited." to the description
- adding to the queue also if the value is not set (Drupal stores empty number fields as "NULL")

sinn’s picture

sinn commented
StatusFileSize
new queue_mail-threshold_unlimited-3155823-6.patch6.12 KB

Solution #5 with the tests

  • sinn committed 684b33f8 on 8.x-1.x 
    Issue #3155823: Ability to send email constantly with unlimited retry...
sinn’s picture

sinn commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.