Problem/Motivation

Steps to reproduce

N/A

Proposed resolution

Fix text failures + add test coverage for new features.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork purge_users-3227269

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

vintimpe made their first commit to this issue’s fork.

vintimpe opened merge request !4

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs work

Tests are still failing.

Andras_Szilagyi made their first commit to this issue’s fork.

selvira’s picture

selvira CreditAttribution: selvira at The Whiteam for European Commission and European Union Institutions, Agencies and Bodies commented
Assigned: Unassigned » selvira
Status: Needs work » Active

Hi, I'm adding the new functionality + test coverage.

selvira’s picture

selvira CreditAttribution: selvira at The Whiteam for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs review
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Needs work

Added a new review.

selvira’s picture

selvira CreditAttribution: selvira at The Whiteam for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs work » Needs review
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Assigned: selvira » Unassigned
Status: Needs review » Reviewed & tested by the community

Great work here! Thank you, @vintimpe, @selvira, @Andras_Szilagyi for working on this, finally the module has test coverage. The nice thing is that, during writing the tests, we've spotted #3227550: Avoid spamming users.

Andras_Szilagyi’s picture

Andras_Szilagyi CreditAttribution: Andras_Szilagyi for European Commission and European Union Institutions, Agencies and Bodies commented

Looks good, just a small fix.
@jimapplebee could you check.
Thank you.

Andras_Szilagyi opened merge request !5

Andras_Szilagyi closed merge request !5

Andras_Szilagyi’s picture

Andras_Szilagyi CreditAttribution: Andras_Szilagyi for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.