Problem/Motivation

Support upgrade of prototype 3.x to Drupal 10. If a site's theme is built using a 3.x version of prototype give an easier upgrade and maintenance path than having to completely rebuild the theme using the 4.x or 5.x branch

Steps to reproduce

Upgrade a site with a prototype based theme from Drupal 9 to 10

Proposed resolution

* Fix dependencies for Drupal 10: components 3.x
* Backport Drupal 10 compatibility fixes from 4.x/5.x to 3.x

CommentFileSizeAuthor
#4 3416902-3.0-alpha1-drupal10.patch1.66 KBmiiimooo

Issue fork prototype-3416902

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3416902-port-3.x Comparechanges, plain diff MR !95
    • 4 hidden branches
  • 3.x Comparecompare
  • 8.x-3.x Comparecompare
  • 3416902-port-3-drupal10 Comparecompare
  • 3416902-port-3.x-for Comparecompare
About issue forks

Comments

miiimooo created an issue. See original summary.

miiimooo’s picture

miiimooo
Location Europe
commented
Version: 8.x-3.x-dev » 8.x-3.0-alpha1
miiimooo’s picture

miiimooo
Location Europe
commented
Title: Port 3.x for Drupal 10 » Upgrade prototype 3.x to Drupal 10
Component: Code » Documentation
Category: Task » Support request
Status: Active » Needs review

The work for this was already done in the 3.x and 4.x branches.

This seems to work for now:

composer require drupal/components:'dev-3.x as 2.4.1'
composer require drupal/prototype:dev-4.x
miiimooo’s picture

miiimooo
Location Europe
commented
Status: Needs review » Needs work
StatusFileSize
new 3416902-3.0-alpha1-drupal10.patch1.66 KB

I spoke to soon. After upgrade to D10 I realised that dev-4.x already includes a lot of the refactoring.

Here is the D10 patch re-rolled for 3.0-alpha1

Applies when doing

composer require drupal/components
composer require 'drupal/prototype:dev-3.x#7823a79c'
miiimooo’s picture

miiimooo
Location Europe
commented

This works but referencing the commit instead of a working branch is ugly and really should avoided.

The underlying problem is that in 3.x two more commits were added (109da268 and 15ebbd47).

The first one of them introduces breaking changes since it moves everything from build/ to dist/

I would argue that this change warrants a new branch and that it should be removed from 3.x

The second change makes a path change which I'm not convinced it is required by 9.5

Please remove this also from the 3.x branch. Unless you can find a reference where the reason for this change is documented

miiimooo’s picture

miiimooo
Location Europe
commented
Issue tags: +Drupal 10 compatibility

miiimooo changed the visibility of the branch 3416902-port-3-drupal10 to hidden.

miiimooo changed the visibility of the branch 3416902-port-3.x-for to hidden.

miiimooo changed the visibility of the branch 8.x-3.x to hidden.

miiimooo opened merge request !95

miiimooo’s picture

miiimooo
Location Europe
commented
Version: 8.x-3.0-alpha1 » 8.x-3.x-dev
Component: Documentation » Code
Category: Support request » Task
Issue tags: +backward compatibility
miiimooo’s picture

miiimooo
Location Europe
commented
Status: Needs work » Needs review 
composer require "drupal/prototype:dev-3.x#15ebbd47"

miiimooo changed the visibility of the branch 3.x to hidden.

pixelwhip’s picture

pixelwhip commented

Thanks for the work on this! Just wanted to let you know this is on our radar and will hopefully be able to review and move it along in the next couple days.

  • jldust committed c219c911 on 8.x-3.x 
    Issue #3416902 - Updating 8.x-3.x for Drupal 10
jldust’s picture

jldust commented
Status: Needs review » Fixed

Thank you for creating a patch, we have created an updated release that supports D10. Please use: composer require 'drupal/prototype:^3.1@alpha'

jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)