Problem/Motivation

There are many variables set with both SASS as well as native CSS, which makes workflow confusing at times.

Proposed resolution

Clean up all of the variables and focus on CSS native properties to make workflow smoother.

Issue fork prototype-3374143

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

philip_stier created an issue. See original summary.

philip_stier opened merge request !49

philip_stier’s picture

philip_stier commented

@jldust - I merged in your updates from the Typography Variables update and have made adjustments accordingly. I kept most of what you put together and tweaked a little here and there, which we can talk about :)

philip_stier’s picture

philip_stier commented

@jldust - I've updated the mixin for fonts per our conversation :)

philip_stier’s picture

philip_stier commented
Status: Active » Needs review
philip_stier’s picture

philip_stier commented
Version: 5.1.x-dev » 5.x-dev

jldust made their first commit to this issue’s fork.

jldust’s picture

jldust commented
Status: Needs review » Fixed

This looks great, thanks for making all those changes. I've merged this in and it will be included in the next release.

jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)