Closed (fixed)
Project:
Prototype
Version:
4.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
30 Sep 2022 at 16:33 UTC
Updated:
13 Dec 2022 at 18:17 UTC
Jump to comment: Most recent
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
philip_stier commented@jldust - I'm sure we'll want to talk about the sweeping changes that I've made prior to merging. I'm happy to go through everything :)
Comment #4
philip_stier commentedComment #5
philip_stier commented@pixelwhip / @jldust - I've refactored all SASS files according to @pixelwhip's feedback. This includes adding a breakpoint mixin and replacing any reference that uses the removed NPM library with the correct mixin. I've also combed through the SASS and resulting CSS and could not finding any need for a font-size transformer – all font sizes were hard-written into ems already.
Comment #6
pixelwhip commentedThanks for the updates. I've added additional notes to the merge request.
Comment #7
philip_stier commented@pixelwhip - Where the only updates to the const variable declarations? Those should all be fixed up now :)
Comment #8
philip_stier commentedComment #9
philip_stier commented@pixelwhip / @jldust - I've removed the tailwind file and references and have also updated the naming convention of breakpoint mixins from up/down to min/max.
Comment #10
philip_stier commented@pixelwhip / @jldust - I've added back the configuration files, both upgrading them and adding documentation to them. I also updated the readme file with more documentation.
Comment #11
jldust commented@philip_stier Thank you for reworking the configuration files & upgrading the documentation. This will be our first new 4.x-alpha release once we merge things in.
Comment #13
jldust commentedThanks for all your work, we have pulled this into the most recent branch.
Comment #15
jldust commentedThis has been added in the new 4.0.0-alpha1 release