Issue fork prototype-3312943

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

philip_stier created an issue. See original summary.

philip_stier’s picture

Issue summary: View changes

@jldust - I'm sure we'll want to talk about the sweeping changes that I've made prior to merging. I'm happy to go through everything :)

philip_stier’s picture

Issue summary: View changes
Status: Active » Needs review
philip_stier’s picture

Issue summary: View changes

@pixelwhip / @jldust - I've refactored all SASS files according to @pixelwhip's feedback. This includes adding a breakpoint mixin and replacing any reference that uses the removed NPM library with the correct mixin. I've also combed through the SASS and resulting CSS and could not finding any need for a font-size transformer – all font sizes were hard-written into ems already.

pixelwhip’s picture

Status: Needs review » Needs work

Thanks for the updates. I've added additional notes to the merge request.

philip_stier’s picture

@pixelwhip - Where the only updates to the const variable declarations? Those should all be fixed up now :)

philip_stier’s picture

Status: Needs work » Needs review
philip_stier’s picture

@pixelwhip / @jldust - I've removed the tailwind file and references and have also updated the naming convention of breakpoint mixins from up/down to min/max.

philip_stier’s picture

@pixelwhip / @jldust - I've added back the configuration files, both upgrading them and adding documentation to them. I also updated the readme file with more documentation.

jldust’s picture

Status: Needs review » Reviewed & tested by the community

@philip_stier Thank you for reworking the configuration files & upgrading the documentation. This will be our first new 4.x-alpha release once we merge things in.

jldust credited b-ry.

jldust’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for all your work, we have pulled this into the most recent branch.

  • 109da26 committed on 4.x
    Issue #3312943 by philip_stier, jldust, pixelwhip, b-ry: Update Frontend...
jldust’s picture

Status: Fixed » Closed (fixed)

This has been added in the new 4.0.0-alpha1 release