Prototype currently depends on components.module, but the dependency is not defined in code. Installing prototype and creating a base theme without also first manually installing components causes a fatal error.

CommentFileSizeAuthor
#6 correctly-handle-dependencie.patch704 bytesb-ry

Issue fork prototype-2964677

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

justin2pin created an issue. See original summary.

brentrobbins’s picture

brentrobbins commented

Hi Justin,
I am not sure if that functionality / capability is integrated into D8 (as of ver 8.6.1) core yet (themes having module dependancies). There is an issue that already discusses the possibility for 8.7-dev: https://www.drupal.org/node/474684

Brent

b-ry’s picture

b-ry commented

Hey,
Looks like there are a couple options.
1) A dependency can be added to the themes .info file which prevents the themes ability to be installed if the dependency is not meet.
i.e. dependencies
- drupal/components
2) Remove the Dependency on the module entirely and add a preprocess hook to do the same thing the module is doing.

Thoughts: if we don't rename the theme for each client it could be easier to just set it. Seems to be a bit more of an issue if the theme is renamed.

jldust’s picture

jldust commented

Hi Bryon, thanks for taking a look into this. For the 2.x branch lets add it to the .info file as a dependency so that users can handle it at install and we don't structurally change the way the theme works.

philip_stier made their first commit to this issue’s fork.

b-ry’s picture

b-ry commented
StatusFileSize
new correctly-handle-dependencie.patch704 bytes

Hey Jennifer, created a patch that adds the components dependency to the info file.

  • 3e3979d committed on 2964677-correctly-handle-dependencies 
    Issue #2964677 Correctly handle dependencies, applying patch

jldust opened merge request !9

  • jldust committed 8ed8a48 on 8.x-2.x 
    Issue #2964677 by b-ry, philip_stier, jldust: Correctly handle...
jldust’s picture

jldust commented
Status: Needs work » Fixed
jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)

Thanks for making that patch, this has been merged in!