This module adds a simple "Only show checked" toggle to the role permissions page (/admin/people/permissions/{role}). When enabled, it hides unchecked permissions, making it easier to review what a role can actually do. It also displays a live counter showing enabled vs total permissions.

Project link

https://www.drupal.org/project/role_permissions_filter

Comments

mxr10 created an issue. See original summary.

vishal.kadam’s picture

Title: [role_permissions_filter] Security opt-in application » [1.0.x] Role Permissions Filter
Issue summary: View changes
Issue tags: -security opt-in
rushikesh raval’s picture

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.


    Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
  • Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

  • It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • Reviewers should show the output of a CLI tool only once per application.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

rushikesh raval’s picture

Status: Needs review » Needs work

Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us; it does not contain enough Drupal code to really assess your skills as a developer.

Do you have any other project hosted on drupal.org that we could instead review? It needs to have most of the commits (but preferably all the commits) done by you, in at least a branch.

mxr10’s picture

Hi,

I've made the requested changes:

1. GitLab CI is now enabled and passing all checks (phpcs, eslint, phpstan, cspell, composer-lint)
2. Fixed all PHP_CodeSniffer errors
3. Code follows Drupal coding standards

You can see the passing pipeline here:
https://git.drupalcode.org/project/role_permissions_filter/-/pipelines

Regarding showing a larger project - this is my first contributed module. I'm happy to continue contributing and improving this module, or contribute to other projects to demonstrate my skills.

I also have other Drupal modules that I uploaded to drupal.org.
These projects were created and developed by me, and most of the commits were done by me in their main branch.

You can review them here:
https://git.drupalcode.org/project/cache_tags_invalidator/-/pipelines
https://git.drupalcode.org/project/content_language_management/-/pipelines

If you need more information about any of these projects, please let me know. I’ll be happy to explain how they work

Thanks for reviewing!

rushikesh raval’s picture

As per #4 please give link your other project on drupal.org for review.

vishal.kadam’s picture

Priority: Normal » Minor

I am changing priority as per Issue priorities.