[D8] Theme Switcher Rules

Hello Amarincolas,

Please run the automated review and check the errors & warnings.

Git errors:

• It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Review of the master branch (commit a934c50):

• Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
  • The INTRODUCTION section is missing.
  • The REQUIREMENTS section is missing.
  • The INSTALLATION section is missing.
  • The CONFIGURATION section is missing.
• Remove the LICENSE, drupal.org packaging will add a LICENSE.txt file automatically.
• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/theme_switcher.module
  --------------------------------------------------------------------------
  FOUND 4 ERRORS AFFECTING 4 LINES
  --------------------------------------------------------------------------
   10 | ERROR | [x] When importing a class with "use", do not include a
      |       |     leading \
   21 | ERROR | [x] Case breaking statements must be followed by a single
      |       |     blank line
   41 | ERROR | [ ] Inline doc block comments are not allowed; use "/*
      |       |     Comment */" or "// Comment" instead
   58 | ERROR | [ ] Inline doc block comments are not allowed; use "/*
      |       |     Comment */" or "// Comment" instead
  --------------------------------------------------------------------------
  PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
  --------------------------------------------------------------------------
  
  Time: 2.36 secs; Memory: 6Mb
  

• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Entity/ThemeSwitcherRule.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   13 | WARNING | @author tags are not usually used in Drupal, because over
      |         | time multiple contributors will touch the code anyway
  --------------------------------------------------------------------------
  
  
  FILE: ...r/drupal/pareviewsh/pareview_temp/src/ThemeSwitcherRuleInterface.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   10 | WARNING | @author tags are not usually used in Drupal, because over
      |         | time multiple contributors will touch the code anyway
  --------------------------------------------------------------------------
  
  
  FILE: ...rupal/pareviewsh/pareview_temp/src/Theme/ThemeSwitcherNegotiator.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   85 | WARNING | Unused variable $machine_name.
  --------------------------------------------------------------------------
  
  
  FILE: ...al/pareviewsh/pareview_temp/src/Form/ThemeSwitcherRuleDeleteForm.php
  --------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  --------------------------------------------------------------------------
   15 | WARNING | @author tags are not usually used in Drupal, because over
      |         | time multiple contributors will touch the code anyway
  --------------------------------------------------------------------------
  
  Time: 1.19 secs; Memory: 4Mb
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Hello Amarincolas,

When i install and add theme switcher rule after that it's showing below errors on log.

Warning: call_user_func() expects parameter 1 to be a valid callback, class 'Drupal\theme_switcher\Form\ThemeSwitcherRuleForm' does not have a method 'exist' in Drupal\Core\Render\Element\MachineName::validateMachineName() (line 267 of core\lib\Drupal\Core\Render\Element\MachineName.php)

Thanks

Hello Amarincolas,

I have tested this module. It is not working with language & webforms conditions. It will set default active theme.

Thank you for your review. We don't aim to debug the code, but check what users understand in correctly using the Drupal core APIs, writing secure code, and writing code that follows the Drupal coding standards.

Thank you for the contribution!
I have not found any security related issues into the code.

Just one small suggestion (which does not come from project security) is always better to use try and catch blocks, and handle possible throws and exceptions.
Good job!

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.