Because Storify is shutting down, this module provides a way to display social media embed code and external pages in a card-like format similar to Storify. It creates paragraph types and a content type that will display a list of the stories a user enters. The paragraphs and lists contain minimal styling so the user can style them to match their needs.

Project URL
https://www.drupal.org/project/news_cards

Git URL
git clone --branch 8.x-1.x https://git.drupal.org/project/news_cards.git

CommentFileSizeAuthor
#9 patch.txt365 bytesleymannx
#2 news_cards-phpcs_coding_errors-2943337-1-D8.patch0 bytesbharath-kondeti
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

blakemorgan created an issue. See original summary.

bharath-kondeti’s picture

bharath-kondeti CreditAttribution: bharath-kondeti commented
FileSize
news_cards-phpcs_coding_errors-2943337-1-D8.patch0 bytes

Iam uploading a patch file for the issue

leymannx’s picture

leymannx
he/him
Primary language German
Location Berlin
CreditAttribution: leymannx commented
Category: Feature request » Task
Issue summary: View changes

- Added Storify link
- Added project URL
- Fixed typo

leymannx’s picture

leymannx
he/him
Primary language German
Location Berlin
CreditAttribution: leymannx commented

gulpfile.js

This module contains a gulpfile.js, a Sass file and npm package.json and lock file. I'm pretty sure as they are only needed for development that they should be removed from your module. Users who download your module are not supposed to make any use of such resources. They should instead override the styling from their own theme.

Module depencies (news_cards.info.yml)

I'm pretty sure you don't need that much dependencies or do you? Please review them thoroughly and remove then ones that ain't necessary for your module to work properly.

README.txt

Please fix your README along the guidelines.

leymannx’s picture

leymannx
he/him
Primary language German
Location Berlin
CreditAttribution: leymannx commented
Status: Needs review » Needs work
blakemorgan’s picture

blakemorgan CreditAttribution: blakemorgan at Brigham Young University commented

I am trying to apply patch #3, but it is empty.

blakemorgan’s picture

blakemorgan CreditAttribution: blakemorgan at Brigham Young University commented

I have removed the dev files, extraneous dependencies, and updated the README as per #4.

blakemorgan’s picture

blakemorgan CreditAttribution: blakemorgan at Brigham Young University commented
Status: Needs work » Needs review
leymannx’s picture

leymannx
he/him
Primary language German
Location Berlin
CreditAttribution: leymannx commented
FileSize
patch.txt365 bytes

Code sniffer found only one missing newline in the info file. That's all.

ashish-deynap’s picture

ashish-deynap CreditAttribution: ashish-deynap at TO THE NEW commented
Status: Needs review » Needs work

Automated Review

Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting.
(./css/paragraphs--stories.css.map: ASCII text, with very long lines, with no line terminators)
Code sniffer found only one missing newline at the end of info file.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
LICENSE.txt is missing.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
leymannx’s picture

leymannx
he/him
Primary language German
Location Berlin
CreditAttribution: leymannx commented

@ashish – LICENSE.txt is not missing.

4.1 Ensure the top directory of the repository does not contain a ‘LICENSE.txt’ (or similar) file.

blakemorgan’s picture

blakemorgan CreditAttribution: blakemorgan at Brigham Young University commented

Committed fixes for #9 and #10.

blakemorgan’s picture

blakemorgan CreditAttribution: blakemorgan at Brigham Young University commented
Status: Needs work » Needs review
sleitner’s picture

sleitner CreditAttribution: sleitner commented
Component: module » feature
Status: Needs review » Reviewed & tested by the community

Automated Review

Review of the 8.x-1.x branch (commit 1b981db):

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity. https://groups.drupal.org/node/186879
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
Feature project: https://groups.drupal.org/node/186879

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Component: feature » module
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution!

I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Assigned: Unassigned » apaderno

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.