Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 May 2016 at 07:08 UTC
Updated:
21 Dec 2016 at 17:25 UTC
Jump to comment: Most recent
Comments
Comment #2
dansboy commentedThere are some errors reported by automated review tools, did you already check them?
See http://pareview.sh/pareview/httpgitdrupalorgsandboxzhengjia2723141git
Comment #3
zhengjia commentedComment #4
jungleHi, @zhengjia
There are two suggestions for you.
1. DON'T use Chinese here.
2. Join in the review bonus program to prioritize your application.
Comment #5
zhengjia commentedComment #6
zhengjia commentedComment #7
PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #8
roychan commentedIndividual user account
Yes
No duplication
Yes
Master Branch
Yes
Licensing
Yes
3rd party assets/code
Yes
README.txt/README.md
No, as suggested by the Module documentation guidelines, a helpful project page with enough information for the user to evaluate whether it will suit their needs is required. However it seems the project page is missing the info. It's also recommend to implement hook_help() although this is not compulsory.
Code long/complex enough for review
Yes
Secure code
Yes
Coding style & Drupal API usage
- (*) Major finding, needs work
Please prefix your function with the module name to avoid name collisions between modules.
e.g. drush/remote_api.drush.inc line 277 function _remove_invalid_entries
- Just a recommendation
Although Drupal is not MVC, it's generally a best practice to put HTML in theme functions. e.g. remote_api_edit_form_preview
Comment #9
roychan commentedComment #10
zhengjia commentedComment #11
zhengjia commentedComment #12
PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #13
zhengjia commentedComment #14
PA robot commentedFixed the git clone URL in the issue summary for non-maintainer users.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #15
sriharsha.uppuluri commentedAutomated Review
Please fix reported issue on https://pareview.sh/node/210
Manual Review
variable_set($prefix . ':' . $field, $value);The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #16
PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.