Remote API module allows Drupal developers to encapsulate remote apis from drupal multi-sites or third party apis. So develoepr can call thoses API in same way and in different mode.

Project Page: https://www.drupal.org/sandbox/zhengjia/2723141

Version: Drupal 7.x-1.x
Git: git clone --branch 7.x-1.x https://git.drupal.org/sandbox/zhengjia/2723141.git remote_api

Comments

zhengjia created an issue. See original summary.

dansboy’s picture

There are some errors reported by automated review tools, did you already check them?
See http://pareview.sh/pareview/httpgitdrupalorgsandboxzhengjia2723141git

zhengjia’s picture

Status: Active » Needs review
jungle’s picture

Status: Needs review » Needs work

Hi, @zhengjia

There are two suggestions for you.

1. DON'T use Chinese here.
2. Join in the review bonus program to prioritize your application.

zhengjia’s picture

Issue summary: View changes
zhengjia’s picture

Status: Needs work » Needs review
PA robot’s picture

Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

roychan’s picture

Individual user account
Yes

No duplication
Yes

Master Branch
Yes

Licensing
Yes

3rd party assets/code
Yes

README.txt/README.md
No, as suggested by the Module documentation guidelines, a helpful project page with enough information for the user to evaluate whether it will suit their needs is required. However it seems the project page is missing the info. It's also recommend to implement hook_help() although this is not compulsory.

Code long/complex enough for review
Yes

Secure code
Yes

Coding style & Drupal API usage
- (*) Major finding, needs work
Please prefix your function with the module name to avoid name collisions between modules.

e.g. drush/remote_api.drush.inc line 277 function _remove_invalid_entries

- Just a recommendation
Although Drupal is not MVC, it's generally a best practice to put HTML in theme functions. e.g. remote_api_edit_form_preview

roychan’s picture

Status: Needs review » Needs work
zhengjia’s picture

Status: Needs work » Needs review
zhengjia’s picture

Issue summary: View changes
PA robot’s picture

Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

zhengjia’s picture

Issue summary: View changes
PA robot’s picture

Issue summary: View changes

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

sriharsha.uppuluri’s picture

Status: Needs review » Needs work

Automated Review

Please fix reported issue on https://pareview.sh/node/210

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause] module duplication and/or fragmentation.
Master Branch
[Yes: Follows] the guidelines for master branch.
Licensing
[Yes: Follows] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[Yes: Follows] the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.
Secure code
[Yes: Meets the security requirements. ]
Coding style & Drupal API usage
List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:
  1. (*) Please remove all variables used in module under hook_uninstall
  2. variable_set($prefix . ':' . $field, $value);

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.