[D7] Waveform.js display formatter

Git clone failed for http://git.drupal.org/sandbox/souless/2352841.git while invoking http://pareview.sh/pareview/httpgitdrupalorgsandboxsouless2352841git

Git clone failed. Aborting.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Since you added non GPL license library you included, please read this question / answer regarding the 3rd party library included in your module https://www.drupal.org/licensing/faq#q10

JS

1. The JS should probably be wrapped using drupal behaviors https://www.drupal.org/node/756722#behaviors, which will mean that it works better on pages which dynamically load content (e.g. ajax views).
2. What if you have more than one waveform on a page? At the moment it's querying on #waveform which is not ideal if there are multiple waveforms. Perhaps consider using classes and find them with jQ
3. There's a lot of options at the top of the JS file - perhaps this could be configured using field settings?

Templating

1. The templating seems to have quite a strong assumption of using the bootstrap css library. What happens if a site doesn't use bootstrap?
2. Do all use cases for this module require full audio controls> Again, these could be controlled with field settings, even if that is just [full, minimal, none] settings.

No duplication
Seems all good, didn't find any duplicates.

Master Branch
Yes, Follows the guidelines for master branch. Please add a git command to your request as per the instructions though, I had to go digging :)

Licensing
Yes, Follows the licensing requirements.

3rd party code
Yes, Follows the guidelines for 3rd party code. No thirdparty code included. Could link directly to "http://www.wavesurfer.fm/build/wavesurfer.min.js" from README though.

README.txt/README.md
Concise install instructions provided - all good!

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.