Name: UserDeck

Description: UserDeck provides customer support software that embeds into your Drupal website.

Features
Guides is a knowledge base widget that embeds inline to any page of your Drupal website.
It inherits your theme's design and blends right in.
You can embed a collection, category, or a single article instead of an entire knowledge base.
Your users will save time by finding answers to common questions through self service.

Sandbox URL: https://www.drupal.org/sandbox/userdeck/2310031

Drupal Version: 7.x

Git Repo:

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/userdeck/2310031.git userdeck
cd userdeck

Comments

userdeck’s picture

userdeck commented
Title: UserDeck » [D7] UserDeck
PA robot’s picture

PA robot commented
Status: Needs review » Needs work

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

jmaties’s picture

jmaties commented

You must include

 git clone --branch 7.x-1.x http://git.drupal.org/sandbox/userdeck/2310031.git userdeck
cd userdeck
userdeck’s picture

userdeck commented
Issue summary: View changes

Added repo url

userdeck’s picture

userdeck commented
Status: Needs work » Needs review
PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxuserdeck2310031git

I'm a robot and this is an automated message from Project Applications Scraper.

userdeck’s picture

userdeck commented
Status: Needs work » Needs review

Updated for coding standards, not sure if the last few items are mandatory or not as I wasn't sure how to fix them.

Ben Howes’s picture

Ben Howes commented
Status: Needs review » Needs work

Automated Testing
You should fix those few issues from automated testing - it's all fairly simple things, like changing Implements hook_node_view. to Implements hook_node_view()..

Manual Review

  1. Javascript should use drupal behaviours to better integrate with drupal.
  2. Long blocks of HTML on the admin pages shouldn't have hardcoded JS and could make better use of built in functions like t and l.
  3. Should use libraries API rather than just embedding a script tag.

Generally looking pretty strong though!

Security
I'm no expert in this field, however, I can see that you can set userdeck_guides_key without any kind of login, with a string which is never checked between then and when it's rendered into the page with userdeck_output_guides_code. This means that any manor of malicious HTML/JS could be added to a page. You need to authenticate this in some form, or request the key from drupal, the model is dangerous at the moment.

PA robot’s picture

PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.