This module adds an option on the vocabulary edit form to allow you to set a limit of depth for the terms in this vocabulary.

Comments

dsim’s picture

Hi,

Currently you are working in master branch, please have a look at Release naming conventions and change accordingly.

Thanks

dsim’s picture

Status: Needs review » Needs work
gmaxime’s picture

Issue summary: View changes
gmaxime’s picture

Hi silambarasan,

Thank you for replying, I changed the branch.

Maxime

gmaxime’s picture

Status: Needs work » Needs review
dsim’s picture

Status: Needs review » Needs work

Hi,

Use 6.x-1.x, 7.x-1.x or 8.x-1.x as your main development branch. you should not have branch name called development.

gmaxime’s picture

Issue summary: View changes
Status: Needs work » Needs review

silambarasan,

Ok, the branch name is now '7.x-1.x', sorry for this it's the first module I submit :)

PA robot’s picture

Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmaximefc2293821git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

gmaxime’s picture

Status: Needs work » Needs review

Code review has been done :)

tsymi’s picture

Status: Needs review » Reviewed & tested by the community
stborchert’s picture

Status: Reviewed & tested by the community » Needs work

@Tsymi setting the status to RTBC without doing a review (or at least without writing down some details of your review) is somehow ... uhm, strange?

There are still some errors found by pareview.sh: http://pareview.sh/pareview/httpgitdrupalorgsandboxmaximefc2293821git.

Notes

* You set the package of your module to "taxonomy". Note that current guidelines suggest that the vast majority of modules should not define a package and therefore fall into the Other category.
* After installation I opened admin/structure/taxonomy/add and got this notice:
"Notice: Undefined property: stdClass::$vid in vocabulary_maximum_depth_form_taxonomy_form_vocabulary_alter() (line 16 of .../pareview/2293865/sites/all/modules/custom/vocabulary_maximum_depth/vocabulary_maximum_depth.module)."

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.