[D7] iPerceptions Surveys

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxiPerceptions1993844git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please fix the most basic coding standard errors first: http://ventral.org/pareview/httpgitdrupalorgsandboxiPerceptions1993844git

iperceptions_surveys.info vs. iperceptions_survey.info: why two info files?

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Hi iPerceptions,

Following are some of the issues that I could find out at the first look at your module.

1) In hook_help there are some strings which are not passed through t() function, Also the formatting is wrong. Kindly correct the formatting use spaces instead of tabs.

2) In iperceptions_survey.install line 12: inappropriate use of get_t
Correct usage:

 $t = get_t();
 $translated = $t('translate this');

3) Do we need to a drupal_set message in hook_install, instead add configure = admin/config/user-interface/iperceptions_survey in .info file

4) echo in hook_init() This is inappropriate. Use hook_page_build or hook_preprocess

Hi

I would suggest using a tpl for your markup rather than writing it as a string in your function iperceptions_survey_help. Here's why I think it's important in my experience:

1. UI/Markup should always be separate from the server side logic.
2. Much better readability for another developer going through your code.

Also, the indentation breaks at various places in your code. Please review the errors in your code at pareview.sh.

Thanks
Raman

Marking again as Needs review, since this HTML is within help function - so not really a blocker.

Please clarify - is there a specific person who is working on this project or is this a company project?

All Drupal user accounts are supposed to be for individuals, not shared groups of people. Likewise, git access to the drupal.org repository is granted to individuals only, not to groups. You may give multiple users access to your project, but each user must have his or her own account on drupal.org, you should not be sharing an account.

This is a company project.

We have created Drupal user accounts for people who will work on the module.
The module has been updated as suggested by rmn in comment #15.

Please review the work.
Thank you.

These aren't show stoppers but I'd like to mention it because you should change them:
- There is still a master branch present.
- There is a thumbs.db that shouldn't be here.

Then there is https://drupal.org/node/1993896#comment-8341305 which is only partially solved, see point 3.

I consider this last point about not using the appropriate API so I will leave this as Needs review.
Otherwise I would have set it to RTBC.

PAReview: Individual user account

It seems you are using a non-individual account.
All user accounts are for individuals. Accounts created for more than one user or those using anonymous mail services will be blocked when discovered (see Get a Drupal.org account).
Please note that organization accounts cannot be approved for git commit access. See https://drupal.org/node/1966218 and https://drupal.org/node/1863498 for details on what is/isn't allowed. Please update your user profile so that we don't have to assume that this is a group account.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.