Webform module usage

Thanks for the feedback.

I was hoping that the maintainers of webform (that is, quicksketch) would accept the patch at
#282436-50: Multiple Options, Same Value in 'Select' Form Element (+ Protect from Spam Harvesters)
or alternatively, develop a built-in solution that does the same, copying privatechoice.

No reactions yet.

I am sure it would be possible to extend privatechoice with some dedicated form_alter code to change webform from the outside, but I think it would be much easier to have the component-specific logic in webform directly.
What should we do?

Looks like a good start.
Should we really make this a new (sub)module, or rather have it enabled by default? Atm I see a higher chance of someone forgetting to enable the privatechoice_webform submodule, than the chance of someone who does not want this extra feature added to webform.

It certainly does improve modularity, though. And it will allow privatechoice_webform to be replaced with something else: A solution built-in with webform, or another module which leverages privatechoice. If admin_menu had that modularity, then dqx_adminmenu would contain less copy-paste.

So, with your approval, I shall include this code as a submodule. And maybe I can make it work for checkboxen and radios, too.

Storage: Would we gain anything from storing this stuff in the webform_component table, instead of a custom variable?

The only real benefit I can imagine at this moment is if there are large numbers of webform nodes, then we can avoid loading their settings all at once. But that is not very likely.

Note: Serialized array in the 'extra' column.

Just sent a contact form message to quicksketch.
Would be nice, if we get some feedback.

And yeah, there might be some hidden treasure in the webform api!

webform 6.x-3.11
privatechoice 6.x-dev

The private choice wasn't working for me when I set the #privatechoice to TRUE. I investigated a bit, and saw the process & element_validate functions weren't being added to the element, so I did it in my hook_form_alter (below). I believe those two lines shouldn't be necessary for me, but it was the only way I could get it to work.

For some reason the privatechoice module's process & element validate functions were only being added/called on the date & time elements on my webform (and not my other select option elements). I tried playing with the module weights in the system table but that didn't seem to do it.

/**
 * Implementation of hook_form_alter().
 */
function MODULE_form_alter(&$form, &$form_state, $form_id) {
  if ($form_id == 'webform_client_form_9') {
    $form['submitted']['number_of_attendees']['#privatechoice'] = TRUE;
    // these two lines shouldn't be necessary?, but here they are
    $form['submitted']['number_of_attendees']['#process'][] = 'privatechoice_process';
    $form['submitted']['number_of_attendees']['#element_validate'][] = 'privatechoice_validate';
  }
}

What is the element type of the $form['submitted']['number_of_attendees'] ?

The #process and #element_validate should be set in function privatechoice_elements() - can you check what is going wrong there?

The #process and #element_validate should be set in function privatechoice_elements() - can you check what is going wrong there?

It seems privatechoice_elements() worked, but only altered the #process and #element_validate for my date/time select options, but not the other select option elements.

the form element #type is radios

Strange.
Could you check if some other module is overwriting the #process and #element_validate?
Not sure where you would have to look..
Or maybe that's a matter of module weight?

Yeah, I tried to figure out if any other modules were altering the form or if the modules' weight were causing them to fire out of order. It is likely some other module is causing this, I just thought I'd share my temporary solution. Hopefully, I'll find time to figure it out soon.

You could visit
yoursite.com/devel/elements
this will give you some useful information :)
(if you have devel enabled)

thanks for the suggestion, it looks like the privatechoice #process & #element_validate functions are there for radios

Now that I think about it, I suspect my issue is caused by my webform module being a bit out of date. It looks like this like in webform/components/select.inc resets those functions (instead of appending them into the array). Although, I am perplexed because the webform module weight is -1, so it shouldn't happen after private choice.
$element['#process'] = array('expand_radios', 'webform_expand_select_ids');

The modifications from hook_elements(), which privatechoice uses, are applied before any hook_form_alter().

I updated to webform 6.x-3.14.

It seems line 366 in webform/components/select.inc sets the #process functions for the radios element. If I comment out that line, privatechoice works (but those process functions from webform obviously don't work). I haven't figure out what prevents all of these process functions (from webform and privatechoice) from being called.

----UPDATE: -----
I made a tweak to webform/components/select.inc. It appears the webform renders the element but doesn't use the #process functions that have already been set by any hook_elements. I am unsure my patch is the correct way to do this....

diff --git a/sites/all/modules/webform/components/select.inc b/sites/all/modules/webform/co
index 8f57f94..3ba6ed6 100644
--- a/sites/all/modules/webform/components/select.inc
+++ b/sites/all/modules/webform/components/select.inc
@@ -363,7 +363,9 @@ function _webform_render_select($component, $value = NULL, $filter = TR
     else {
       // Set display as a radio set.
       $element['#type'] = 'radios';
-      $element['#process'] = array('expand_radios', 'webform_expand_select_ids');
+      $all_elements = module_invoke_all('elements');
+      $element['#process'] = $all_elements['radios']['#process'];
+      $element['#process'][] ='webform_expand_select_ids';
     }
   }

I found this issue was already pointed out in the Webform issue queue: http://drupal.org/node/1188774#comment-5219542
So, the problem is in webform not privatechoice. Thanks for the help, hopefully the webform module maintainer fixes this issue soon.