Problem when parsing "a name" tags.

I'm also having problems with "a name" followed by "a href" (Drupal 4.7.3, print.module 1.6.2.7).

<a name="bookmark01"></a>Chapter 1.<br>
Bla-bla-bla... 
<a href="http://www.example.com">www.example.com</a>. And so on.

With this example, any text between "a name" and "a href" tags (Chapter 1. Bla-bla-bla...) is not displayed in the print view -- seems like print.module cannot understand bookmarks.

It seems like the best way to solve this is to tweak the url regular expression slightly. (I have not got a clean copy of print.module right now to make a patch)

The main thing to change is the ".*" after the initial A tag. If this gets replaced with "[^>]*", it seems to work fine.

So a manual patch (approx line 239):

Replace
$pattern = "@]*)([^>]*)>(.+?)@ise";
with
$pattern = "@]*?href=([\']?[\"]?)([^\"|^\'|^|^>]*)([^>]*)>(.+?)@ise";

Hmm. Let me escape that:

<code>
  Replace: 
   $pattern = "@<a.*?href=([\']?[\"]?)([^\"|^\'|^|^>]*)([^>]*)>(.+?)</a>@ise";
  With: 
   $pattern = "@<a[^>]*?href=([\']?[\"]?)([^\"|^\'|^|^>]*)([^>]*)>(.+?)</a>@ise";

The included patch works for me on 4.7.4 with the latest version of the print module. Thanks!

I have the very same problem in 5.1 also

I have the very same problem in 5.1 also

I have the very same problem in 5.1 also

I have the very same problem in 5.1 also

I just installed the 5.1 version and had the same problem. However, the patch contributed on Nov. 20, 2006 fixed it. Just open print.module in a text editor, and replace $pattern with the code given above.Thanks for sharing that patch!

Patch applied to HEAD

My suggestion:
'@\s]+)\s*[\x22\x27]?[^>]*>([^<]+)<\/a>@eis'

Only 2 groups capturing.

Ops...

'@<a(?:(?!href=).)+href=[\x22\x27]?\s*([^\x22\x27>\s]+)\s*[\x22\x27]?[^>]*>([^<]+)<\/a>@eis'

Thanks for your suggestion. However the code in the 5.x branch is now completely different..

To be able to navigate around "a alt="href=" href="the_url", I had to abandon that simple pattern matching and develop a more robust algorithm.

Try the new 5.x-2.n versions and tell me what you think of them.