Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Working on demo_umami (Out of the box demo core profile) many strings (from fields, views, etc) are missing from https://localize.drupal.org
These fields are available for translation in the UI of the Drupal site which that profile was installed on.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 3042842-10-d7.patch | 1.08 KB | Gábor Hojtsy |
| #10 | 3042842-10.patch | 1.07 KB | Gábor Hojtsy |
| #7 | 3042842.patch | 1.08 KB | Gábor Hojtsy |
| #6 | 3042842-5.patch | 1.89 KB | Gábor Hojtsy |
| #3 | missing-strings-demo_umami-3042842-3.patch | 968 bytes | shaal |
Comments
Comment #2
shaal@gabor said:
The schema used is based on the dependencies identified and those don't seem to be identified here well.
_potx parse yaml file is where the info dependencies are stored for parsing them for config schema
it takes the dependencies array but not the install array which install profiles use.
and suggested creating this patch.
This patch bring many more strings from demo_umami, but there are many still missing.
For an example, the field label "Ingredients" in the Recipe content type.
When I hacked the module, by adding to /modules/contrib/potx/yaml_translation_patterns.yml:
running
drush potx --folder=/var/www/html/core/profiles/demo_umami/config/installDID extract the "Ingredients" field label and many more.Comment #3
shaalI added the hack to this patch as well. It seems to be adding exactly the missing fields from demo_umami core profile when running `drush potx`.
It now finds these missing strings that were not there before:
> msgid "Administrator"
> msgid "Banner image"
> msgid "Block the selected user(s)"
> msgid "Cancel the selected user account(s)"
> msgid "Content Link"
> msgid "Cooking time"
> msgid "Copyright"
> msgid "Difficulty"
> msgid "Disclaimer"
> msgid "Easy"
> msgid "Editor"
> msgid "Find out more link"
> msgid "German"
> msgid "Hard"
> msgid "Ingredients"
> msgid "Make content sticky"
> msgid "Make content unsticky"
> msgid "Media Library thumbnail (220x220)"
> msgid "Name (A-Z)"
> msgid "Name (Z-A)"
> msgid "Number of servings"
> msgid "Overridden block the selected user(s)"
> msgid "Preparation time"
> msgid "Promo image"
> msgid "Promo text"
> msgid "Promo title"
> msgid "Promote content to front page"
> msgid "Publish content"
> msgid "Recipe instruction"
> msgid "Remove content from front page"
> msgid "Unblock the selected user(s)"
> msgid "Unpublish content"
> msgid "above"
> msgid "inline"
> msgid "visually_hidden"
Comment #4
Gábor HojtsyWe need to ignore the hack, that is not going to help. Here are the config files found with #2 that are otherwise not found:
None of the field files seem to be found in install profiles still. That said, other modules, eg. book and forum ship with optional fields and those are found.
etc.
Comment #5
Gábor HojtsyHere is a debugging patch. It shows the extent of the problem is much wider :(
When run on core I get this:
My suspicion is this is an issue with dependency management in how config schema is read since core finds these along the same core schemas, so it must be how we read the config schemas.
Comment #6
Gábor HojtsyAbove results produced with this patch.
Comment #7
Gábor HojtsyYeah the drupal: namespace prefix for dependencies was what broke potx's dependency parsing. This founds schema for all config files, except
But these two from tests I would not expect to have schema.
Ideally this would come with some test coverage expansion but the fix we have at least.
Comment #8
shaalAll missing strings of demo_umami that are listed in #3, and many many more (from views, etc.) are now available in
general.potfile, after applying patch #7.Comment #9
Gábor HojtsyRetitle for actual problem.
Comment #10
Gábor HojtsyLooked into providing test coverage but the dependency resolution of config and modules for config does not seem to be actually tested AT ALL. So should have some general test coverage for that first.
Also looking at https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-... and the apparently existing code at #2983584: Comprehensive solution for potx config project:module format dependencies and #3014336: Handle the project:module format for dependencies to extract translatable strings from config: the l10n_server part., there are more types of qualified project names that would need to be parsed so slightly adjusted. Still runs the same on core.
Comment #12
Gábor HojtsyRerolled it for 7.x-3.x too. Let's run tests on this as well, so we can roll it out on l.d.o.
Comment #14
Gábor HojtsyComment #15
Gábor Hojtsy@drumm rolled this out on l.d.o just now.
Comment #16
jhodgdonI think 8.6.x needs to be reparsed for this, or maybe it is still in progress?
Comment #17
Gábor HojtsyI sent the latest 8.6 release for reparsing, not going to send all of them as I don't think that is helpful.
Comment #18
Gábor HojtsyWas 9080 strings before reparsing, came back with 9178 strings. Looks good to me :)
Comment #19
jhodgdonWoot! This has been bothering me since I first made translation screenshots of the User Guide, back in the 8.2 days. Sorry it took me so long to file an issue... or maybe I did make one... let's see. Oh yeah:
#2806065: Theme region names are not making it into PO database
I'll mark that as a duplicate of this issue. Doh!
Comment #20
jhodgdonOops that is a duplciate of a different issue, sorry.