Please add poll entity and current view mode for poll result template.

CommentFileSizeAuthor
#6 add_poll_entity_and-2874140-6.patch1.59 KBnevergone
#4 add_poll_entity_and-2874140-4.patch0 bytesnevergone
#2 add_poll_entity_and-2874140-2.patch1.59 KBnevergone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nevergone created an issue. See original summary.

nevergone’s picture

nevergone CreditAttribution: nevergone commented
FileSize
add_poll_entity_and-2874140-2.patch1.59 KB
nevergone’s picture

nevergone CreditAttribution: nevergone commented
Status: Active » Needs review
nevergone’s picture

nevergone CreditAttribution: nevergone commented
FileSize
add_poll_entity_and-2874140-4.patch0 bytes

Change default view mode.

Status: Needs review » Needs work

The last submitted patch, 4: add_poll_entity_and-2874140-4.patch, failed testing.

nevergone’s picture

nevergone CreditAttribution: nevergone commented
FileSize
add_poll_entity_and-2874140-6.patch1.59 KB
nevergone’s picture

nevergone CreditAttribution: nevergone commented
Status: Needs work » Needs review
nevergone’s picture

nevergone CreditAttribution: nevergone commented

Please review this issue.

nevergone’s picture

nevergone CreditAttribution: nevergone commented

.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Thanks, committed.

Those templates are all a bit weird, quite possibly this could be rewritten into a single template to make it easier to customize in a single place, but that would be a BC break and break customizations of that template.

  • Berdir committed c8a8bfc on 8.x-1.x authored by nevergone 
    Issue #2874140 by nevergone: Add poll entity and view mode for...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
CreditAttribution: kristiaanvandeneynde at Deeson commented

Just out of curiosity, does this not also account as a BC break?

-  function showPollResults(PollInterface $poll, $block = FALSE) {
+  function showPollResults(PollInterface $poll, $view_mode = 'default', $block = FALSE) {

Mentioning it because the function is public, even though I don't see why anyone would call it directly.