Thanks for this great tool.

When used with filefield path's module:

a. The directory path gets generated the manner filefield path's module is configured which is GREAT
b. The file name however is changed by Plup. a thing that causes:
c. Difficulty locating the file later with filefield sources module
d. filefield sources module doesn't show when using the plup widget
e. insert module doesn't show when using the plup widget

Note: with filefield path's it generates some undefined index errors in php.

Lovely and I will happily test even better releases.

Comments

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Closed (won't fix)

"d. filefield sources module doesn't show when using the plup widget
e. insert module doesn't show when using the plup widget" - I don't know what those are so until I'll use them there won't be fix for it.

The file names are in my to do list so be patient.

W.M.’s picture

W.M. commented

@ivanjaros

It can be that patches are needed to those other modules, not plup. It can be that we need to make them load if they detect the plup widget, that's it.

Fidelix’s picture

Fidelix commented
Category: bug » feature
Status: Closed (won't fix) » Active

@ivanjaros, the filefield_sources module and the insert module are widely used, VERY popular modules:

Filefield Sources has 19728 reported sites running it.
The Insert module has 32289 reported sites running it.

Please, if possible, consider again integrating with them.

gmclelland’s picture

gmclelland commented

I'm getting the undefined index errors as well.
This issue in File Field Paths module could be related #1434370: File (Field) Paths filename issue.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Closed (won't fix)

@gmclelland that has nothing to do with this module.

Fidelix’s picture

Fidelix commented
Title: Inser & Filefield sources integration » Insert & Filefield sources integration

@ivanjaros, this issue is a feature request.

By setting it to "closed (won't fix)", are you declining it?

gmclelland’s picture

gmclelland commented

@ivanjaros - Could you explain how that issue has nothing to do with this module.

In http://drupal.org/node/1434370#comment-5645498 I describe how using a field with plup and filefield paths causes the undefined index errors. For some reason it may be filefield paths that it causing the problem or it maybe that plup is causing the problem. I don't know yet.

I do know that filefield paths work fine when using the standard file and image fields along with their built in formatters.

Fidelix’s picture

Fidelix commented

gmclelland, filefield_sources and filefield_paths are totally different modules. This issue is about Insert & Filefield sources integration.

The problem you are referring to relates to filefield_paths, and even though I can confirm the problem, since it's happening with me as well, you should open a new issue and file this bug.

gmclelland’s picture

gmclelland commented

@Fidelix - Here is the new issue as suggested #1454504: Plup + Filefield Paths = Index Errors

ckng’s picture

ckng
Primary language English
commented
Status: Closed (won't fix) » Active

Reopen, let's keep this open so discussion and work can be done here.
The integration should come from this module instead of the other way around.

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Closed (won't fix)

I want to keep this module as simple as possible so if you want to support those modules you should create a bridge for them as new project. Or contact author of plupload.

Fidelix’s picture

Fidelix commented

Or a fork of your module.
I see no reason not to implement this in this module, or on an optional submodule. A bridge between 2 simple modules is not justifiable.

It is heartbreaking to see that you won't accept patches or suggestions, since we are on a community in which its main strength is collaboration.

Anonymous’s picture

Anonymous (not verified) commented

@fidelix: I've created this module for a project I'm working on and I had to take into account the needs of the project. So I'm not gonna make this some super-ultra-mega-universal module. It does what I need it for and that's that. If you are unhappy with it don't use it or fork it. It's open source after all.

Fidelix’s picture

Fidelix commented

@ivanjaros, I don't see how adding/accepting patches for optional features to the module would conflict with the needs of your project.

It's optional, after all. Anyway, good luck with your project.
I do hope someone who needs this features (I don't) forks this module and takes the community a little more into consideration.

jackhutton’s picture

jackhutton commented

the file names are nonsensical / seo-negative file names. Too bad. A useful - very useful tool..