I get a messed up header block with 6.x-1.1, 6.x-1.x-dev and 5.x-1.1. See picture. The text overlaps on lines because the line-height is 0 for table#header in style.css.

Also the header block is themed by block.tpl.php and there are extra css classes that aren't being used, so I wonder how the header block was intended to look. Like a sticky node, a normal block, or just plain.

There is a an empty div around <?php print header ?> so is this incomplete? It wouldn't be hard to add a id="header_block" in there and add some style, round corners are built in.

Anyone seen this??

CommentFileSizeAuthor
pixture-header-block.gif8.91 KBlevel02
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jeff Burnz’s picture

Assigned: Unassigned » Jeff Burnz

Duly noted. A comprehensive review of all code is in the works, thanks for the bug report.

Jeff Burnz’s picture

What do you think level02, I think those header blocks should have no style - no rounded corners and no background colours, since that region is most likely to be used for a banner.

I.E. we just bang an id=header on the div and rip the styling off blocks.

If you can do this an submit a patch that would be great.