We are using only United States and when entering a number such as "305-555", the field accepts it and enters that into the field for the node. There should be better validation of number formats to ensure that there is a real phone number entered.

CommentFileSizeAuthor
#3 Show-form-error-message-1697922-3.patch587 byteschrisarusso

Comments

g1smd’s picture

g1smd commented

I've previously suggested integrating libphonenumber data into Drupal.

It contains range and length validation routines and formatting patterns for 228+ countries.

chrisarusso’s picture

chrisarusso commented

My experience is validation works, in that it stops the form from submitting, but no form error message is visible, and phone field is not highlighted, so user has no idea why submission hasn't worked. Researching as to why...

chrisarusso’s picture

chrisarusso commented
StatusFileSize
new Show-form-error-message-1697922-3.patch587 bytes

Here's a patch that adheres to drupal standard format, and presents the user with the message (s)he expects to see.

chrisarusso’s picture

chrisarusso commented
Status: Active » Needs review

Needs review

slcp’s picture

slcp commented
Status: Needs review » Closed (duplicate)

Closed as duplicate of these issues - #1715380: Notice: Undefined index: message in field_default_form_errors() (line 381 of /var/www/drupal/modules/field/field.form.inc). + #1783770: phone_field_validate does not properly report validation error.

All of these issue are providing the same patch. The above are RTBC.