Problem/Motivation

See https://www.datatrans.ch/alias-tokenization/using-the-alias (at the bottom) and https://www.datatrans.ch/showcase/authorisation/xml-authorisation

Proposed resolution

Implement it as a new payment method.

CommentFileSizeAuthor
#8 datatrans-xml-2688495-8.patch25.99 KBBerdir
#7 datatrans-xml-2688495-7-interdiff.txt10.88 KBBerdir
#7 datatrans-xml-2688495-7.patch44.64 KBBerdir
#6 xml-2688495-6.patch25.97 KBArla
#6 xml-2688495-6.interdiff.txt1.5 KBArla
#5 xml-2688495-4.patch25.97 KBArla
#5 xml-2688495-4.interdiff.txt12.16 KBArla
#5 xml-2688495-2.patch27.76 KBArla
#4 xml-2688495-4.patch9.59 KBArla
#2 xml_payment_method-2688495-2.patch27.86 KBs_leu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

s_leu created an issue. See original summary.

s_leu’s picture

s_leu CreditAttribution: s_leu at MD Systems GmbH commented
FileSize
xml_payment_method-2688495-2.patch27.86 KB

Adding what i had so far.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs work 
  1. +++ b/src/Plugin/Payment/Method/DatatransXMLDeriver.php
@@ -0,0 +1,83 @@
+              'hmac_key_2' => $configuration_plugin->getHmacKeyTwo(),
+              'use_hmac_2' => $configuration_plugin->getUseHmacTwo(),

    copied from the other one, but I'm pretty sure we will not need them. this was needed on the return page, to sign their response. That's not necessary, there is only one API call and their response to it. 

  2. +++ b/src/Plugin/Payment/Method/DatatransXMLMethod.php
@@ -0,0 +1,85 @@
+    $request->addHeader('If-Modified-Since', gmdate(DATE_RFC1123, $last_fetched));

    I don't think we need this, just $client->post() is probably enough?

Arla’s picture

Arla
they/them
CreditAttribution: Arla at MD Systems GmbH commented
FileSize
xml-2688495-4.patch9.59 KB

Removed hmac2 parameters. Also made other changes while testing. Still not fully functional.

Arla’s picture

Arla
they/them
CreditAttribution: Arla at MD Systems GmbH commented
FileSize
xml-2688495-2.patch27.76 KB
xml-2688495-4.interdiff.txt12.16 KB
xml-2688495-4.patch25.97 KB

Uh, both patches are bad. Remaking, with interdiff.

Arla’s picture

Arla
they/them
CreditAttribution: Arla at MD Systems GmbH commented
FileSize
xml-2688495-6.interdiff.txt1.5 KB
xml-2688495-6.patch25.97 KB

Tested a bit, had to change the request XML.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
datatrans-xml-2688495-7.patch44.64 KB
datatrans-xml-2688495-7-interdiff.txt10.88 KB

This is the working patch, fixed some bugs, renamed and removed some configuration variables.

Yes, the broken aliases are indeed a test account problem, works with a different test account that I have.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
datatrans-xml-2688495-8.patch25.99 KB

That patch was wrong, another try.

  • Berdir committed 4527d41 on 8.x-1.x 
    Issue #2688495 by Arla, Berdir, s_leu: Add XML payment method
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.