Problem/Motivation

The cache bins for discovered pattern libraries and pattern definitions are currently being loaded into the discovery cache bin, but by default this bin is backed using the chained fast backend. Since this cache data doesn't change frequently and is typically only loaded and written once per request, this may work better going into the database cache by default where it can more easily be shared between web heads as well. If this gets separated to an independent new bin this can be backed by the database by default while still allowing individual sites to customize the data handling as desired.

Steps to reproduce

  1. Clear all caches
  2. View the cache_discovery database table
  3. Observe the presence of the following cid entries:
    • patternkit.library_namespaces
    • patternkit_pattern_defintiions:*

After this change, these cache entries should be stored in the cache_patternkit table instead.

Proposed resolution

Create a new patternkit cache bin
Inject the new bin into related services
Store library namespaces and pattern definitions in new cache bin

Remaining tasks

User interface changes

None

API changes

None

Data model changes

New cache_patternkit database table

CommentFileSizeAuthor
#4 5078_Retest.odt1 MBminsharm

Issue fork patternkit-3419287

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

slucero created an issue. See original summary.

slucero’s picture

Status: Active » Needs review
minsharm’s picture

StatusFileSize
new1 MB

Retested the issue and result looks good to me. Marking it as Verified QA.

Steps to test

  • Clear all caches
  • View the cache_discovery database table
  • Observe the presence of the following cid entries:
    • patternkit.library_namespaces
    • patternkit_pattern_defintiions:*
  • Take the latest changes of this feature branch.

Results : These cache entries is stored in the cache_patternkit table instead.

  • slucero committed 799c6946 on 9.1.x
    Issue #3419287 by slucero, minsharm: Separate Patternkit Caches From...
slucero’s picture

Status: Needs review » Fixed

Merged for inclusion in the beta 9 release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.