Note sure if this is a duplicate issue of this, if so we can close this.
https://www.drupal.org/project/patternkit/issues/3113545
Steps to reproduce
- Use Drupal core 9.2.5
- Applied the fix patch https://www.drupal.org/files/issues/2021-11-03/2946333-9.2.x-260.patch, so you don't have to use layout_builder_st.
- Enable locale
- Enable content_translation
- Enable patternkit
- Enable config_translation
- Create a content with layout builder enable
- Save the node
- Go to layout and add in a patternkit block
- Now save the layout
- Click on the translation tab and add another translation
- Click save to save that node in another translation
- Click the layout tabs
- Hover over the pattern kit block and hit translate.
- Notice only field visible is the description field.
The pattern kit field should be all visible and allow for translation.
Things I've notice is the javascript does not load when doing the translation.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | translate-patternkit-block-fix-via-lb-3251763-10.patch | 19.62 KB | johnle |
Issue fork patternkit-3251763
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
cyb_tachyon commentedI am now working on a patch.
Comment #4
cyb_tachyon commentedCode in review :)
Comment #5
johnle commentedSo i've debug this issue, and it's failing at
I've confirmed the file is there and the namespace is correct. I've tested this with some of the classes that are in that directory and they all seem to work except for this one.
When I restart by docker instance, it worked, which leads me to believe it maybe a file caching issue not discovering the new class that was added. I've thought a drush cr would do the trick but looks like it may need to also do a registry rebuild of some sort?
Comment #6
johnle commentedComment #7
johnle commented@cyb.tachyon
Ah cool let me re-test that with the hook update and get the patch updated once that works. Thanks.
Comment #8
johnle commentedI was not able to reproduce the InvalidPluginDefinitionException any longer for me to test this patch. @cyb.tachyon, if you still have that error, you mind testing out the latest changes with the updb?
Comment #9
johnle commentedLooks like there is a bug where when it is adding a new block for a new translation, it flag the new patternkit block as the new source. This is not the same behavior that core content block does its. We don't see the issue here, but when trying to use other modules this can break when loading the patternkit block.
Comment #10
johnle commentedAdding the diff patch from the merge request.
Comment #13
mariohernandez commentedSuccessfully tested patch with core version 9.3.3.
Comment #14
mariohernandez commentedComment #16
mariohernandez commented