Problem/Motivation

Add to the path something like 'demandes-d’accès-à-l’information-complétées' and it goes into an endless loop until it eventually times out.

Proposed resolution

Use explode and implode instead of strrpos and substr.

Remaining tasks

* Add patch.

CommentFileSizeAuthor
#6 path_alias_xt_2341203_fix_endless_loop_1.patch1.81 KBBogdan1988
#2 path_alias_xt_2341203_fix_endless_loop.patch1.81 KBFabianx
#1 path_alias_xt_2341203_fix_endless_loop.patch1.27 KBFabianx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
FileSize
path_alias_xt_2341203_fix_endless_loop.patch1.27 KB

Here is a patch.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Status: Active » Needs review
FileSize
path_alias_xt_2341203_fix_endless_loop.patch1.81 KB

The reason is that strrpos is not unicode safe, using explode / implode however works.

Last patch missed one drupal_substr usage.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Patch looks good.

Bogdan1988’s picture

Bogdan1988 CreditAttribution: Bogdan1988 commented

For me this patch doesn't work for edit pages. I had to change this line
$path = $src . '/' . implode('/', $path_suffix);
Only after adding extra '/' edit pages work well. Thank you.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Status: Reviewed & tested by the community » Needs work

CNW based on that comment

Bogdan1988’s picture

Bogdan1988 CreditAttribution: Bogdan1988 commented
FileSize
path_alias_xt_2341203_fix_endless_loop_1.patch1.81 KB
RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer commented

Thanks Fabianx and Bogdan1988 for the combined effort and patch!
Hope to get to this soon.
Rik

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Status: Needs work » Needs review

Thanks, RdeBoer

Bogdan1988’s picture

Bogdan1988 CreditAttribution: Bogdan1988 commented

Thank you, RdeBoer

  • adriancid committed eb13da5 on 7.x-1.x 
    Issue #2341203 by Fabianx, Bogdan1988, adriancid: Endless loop when...

adriancid credited adriancid.

adriancid credited adriancid.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Status: Needs review » Fixed

Thanks @all for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.