Follow-up from #614120: 2.x feeds module version
- Tests break in PHP 5.2.x
- Can we call FeedsIcalDateParser.inc ParserIcalParser.inc (same for class names), tests/feeds_mapper_ical.test tests/parser_ical_feeds.test, and FeedsMapperiCalTestCase ParserIcalFeedsTestCase? This would be the recommended naming convention. Ekes: the final call here is up to you - renaming would also need your help as CVS committer.
Will post a patch with minor cleanups.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 685942-3_feeds_fixes.patch | 12.98 KB | alex_b |
| #2 | 685942-2_feeds_school.patch | 9.71 KB | David Goode |
| #1 | 685942-1_feeds_fixes.patch | 3.04 KB | alex_b |
Comments
Comment #1
alex_b commented- Code style
- Comments
Comment #2
David Goode commentedHey, the tests actually break pending this patch to date module, which I have applied locally: #675234: Deprecated timezones ignored rather than converted. The test feed includes timezones such as "US/Eastern", which date module silently ignores by default, but which that patch would transform to valid timezones like "America/Montreal". To fix it without requiring that patch, the tests should use "America/Montreal" or similar instead of "US/Eastern". Attached is a patch that only changes the school feed; doesn't include alex's changes, apply that patch in addition.
Comment #3
alex_b commented#3: I can confirm, all tests passing now.
Rerolled containing changes in #1 and #2.
What's open now is the file/class renaming outlined in the initial post:
Otherwise this patch is RTBC.
Comment #4
whatdoesitwant commentedfollowing
Comment #5
ekes commentedCommitted, changed file and class names.
Added some more tests. So far it's clear it's breaking with all day events #689152. I'll close this and start making individual issues from here.