For the development of the excellent http://drupal.org/project/feeds module an ical parser plugin.

CommentFileSizeAuthor
#6 614120-6_icalparser.patch18.16 KBDavid Goode
#5 tests.zip6.07 KBDavid Goode
#3 61412-4_icalfeeds.patch5.45 KBDavid Goode

Comments

ekes’s picture

ekes commented

Development started in HEAD http://drupal.org/cvs?commit=279794 the equivalent of a date mapper will be needed and this may change how things go into the arrays.

whatdoesitwant’s picture

whatdoesitwant commented

@ekes Good to see that you started this up. Are you referring to the new Feedapi replacement module Feeds? Would your linked files allow me to re-enable Ical parser with Feeds?

David Goode’s picture

David Goode commented
StatusFileSize
new 61412-4_icalfeeds.patch5.45 KB

Hey! I've been working on the date mapper in question for feeds here: #623448: Port FeedAPI Mappers: date. Here is the ical parser patch to go with it once that's settled.

alex_b’s picture

alex_b commented

Looking good.

- FeedsIcalDateTimeField class needs commenting
- Needs tests (I know they're in the works). After #623448: Port FeedAPI Mappers: date will shed its TZ tests, iCal parser should contain some tests for TZ handling.

David Goode’s picture

David Goode commented
Status: Active » Needs review
StatusFileSize
new tests.zip6.07 KB

Here is an ical parser test to go along with #3.

David Goode’s picture

David Goode commented
StatusFileSize
new 614120-6_icalparser.patch18.16 KB

Here is an improved patch, includes tests so ignore the zip file and patch of my previous posts.

ekes’s picture

ekes commented

Great stuff. Think moving the TZ stuff makes sense too. Cheers! Committed to head.
Still getting a fair few warnings to investigate. I'll also look into cleaning up the Date side of it, and making it more extensible.

alex_b’s picture

alex_b commented
Status: Needs review » Fixed

ekes: tks for committing.

I've opened an issue for follow up cleanups and bugs: #685942: Feeds integration cleanup. Setting this to fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.