Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 12.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD12" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
You have a few options for how to use this issue:
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD12" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD12" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD12" tag.
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 12 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Using the patches
Using the merge request
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare changes, plain diff MR !17
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 12 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 12! 🎉
Therefore these changes update the
info.ymlfile for Drupal 12 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #4
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 12 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 12! 🎉
Therefore these changes update the
info.ymlfile for Drupal 12 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #5
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 12 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 12! 🎉
Therefore these changes update the
info.ymlfile for Drupal 12 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 12 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #19
marcelovaniMerged as MR !18.
Tested against Drupal 10.6.15, 11.4.5 and 12.0-dev. Drupal 10 and 11 both work: full test suite green, and the embed flow verified by hand in the browser with a clean watchdog.
Drupal 12 is not reachable, but not because of this module — its own tests pass there. Paragraphs, Embed, Entity Embed and Inline Entity Form have no branch declaring
^12, so Drupal refuses to install them. With the constraints relaxed the way the next-major CI job does it, Entity Reference Revisions then callsviews_field_default_views_data()from a procedural.views.incthat Drupal 12 no longer loads, and every page 500s. That wait is tracked in #3619183.The bot patch was the starting point, but most of the work turned out to be elsewhere. The one that mattered most: the module's only test file was named
ParagraphsIEFTests.php, and PHPUnit only collects*Test.php, so neitherrun-tests.shnor the CI phpunit jobs had ever run it — the pipeline reported green over a suite that never executed. Renaming it surfaced everything below.Fixed here, each with a regression test confirmed to fail without its fix:
field.storage.node.body, which the install profile provides rather than the module, and its search_result display depended on a view mode that only exists with the Search module. Body is now the module's ownfield_ief_bodywith its own storage, and the search_result display moved toconfig/optional.image_uploadsub-keys that have no schema while uploads are disabled, so every test installing it failed strict config schema checking.data-entity-uuidunguarded and rancurrent()over the loaded paragraphs, so a deleted paragraph gave FALSE and callingid()on it was fatal.hook_views_data()procedurally, which was 500ing every page on Drupal 12.On CI:
OPT_IN_TEST_NEXT_MINORandOPT_IN_TEST_NEXT_MAJORwere already set, but those only create the jobs._AUTORUN_NEXT_MINORand_AUTORUN_NEXT_MAJORdefault tonone, which leaves them manual, so they never ran and the pipeline still reported green. Both are nowall. phpcs and phpstan pass against current core and no longer allow failure; the next major jobs stay advisory until the dependencies land.core_version_requirementis now^10.3 || ^11 || ^12. 10.1 and 10.2 are end of life and Entity Browser 2.17 requires^10.3, so they were never versions this could be installed on.Comment #20
marcelovani