Problem/Motivation

While using the "experimental" paragraphs widget, when you "Remove" a paragraph and then click either "Collapse all" or "Edit all", the removed paragraphs is restored.

Proposed resolution

Adjust ParagraphsWidget::changeAllEditModeSubmit so that it does not change the 'mode' of a paragraphs, if it is set to 'remove'.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 stop_collapse_all_and-2896867-7.patch2.53 KBVladimirMarko
#7 interdiff-2896867-3-7.txt1.41 KBVladimirMarko
#7 stop_collapse_all_and-2896867-7-test-only.patch1.41 KBVladimirMarko
#3 stop_collapse_all_and-2896867-3.patch1022 bytesVladimirMarko

Comments

VladimirMarko created an issue. See original summary.

VladimirMarko’s picture

VladimirMarko commented
Related issues: +#2738645: Add a collapse / edit all button, +#2896115: Autocollapse all Paragraphs except current
VladimirMarko’s picture

VladimirMarko commented
StatusFileSize
new stop_collapse_all_and-2896867-3.patch1022 bytes

Fixed the bug. Test coverage still needs to be expanded.

VladimirMarko’s picture

VladimirMarko commented
Status: Active » Needs review
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Needs work

So for a regression, we need test coverage.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Priority: Normal » Major

This got off my radar. Raising prio.

VladimirMarko’s picture

VladimirMarko commented
Status: Needs work » Needs review
StatusFileSize
new stop_collapse_all_and-2896867-7-test-only.patch1.41 KB
new interdiff-2896867-3-7.txt1.41 KB
new stop_collapse_all_and-2896867-7.patch2.53 KB

Added a test.

The last submitted patch, 7: stop_collapse_all_and-2896867-7-test-only.patch, failed testing. View results

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Committed, thx.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.