Autocollapse all Paragraphs except current

Some thoughts:

Despite what I said, adding it as a separate setting (with a description saying that it only makes sense in combination with edit mode closed/preview) should actually be much easier to implement, as you don't need to touch the dozen existing closed checks.

Might be enough to just implement this in the submit callbacks, similar to colapse all/edit all

I left out the "Leaves only" option, as traversing the the form looking for leaves is too complicated right now.

This works, but it still needs tests.

Fixed the undeleting bug. This is still missing the tests.

Follow-up: This should interact with "Expand all" / "Collapse all" button.

That is already implemented here.

I made the closed_mode and autocollapse properties belong to the state of the whole widget, instead of its individual items.

Duplicating paragraphs or adding new ones now closes all the others.

Fixed the widget configuration schema.

Tests are still missing.

Now, there should no longer be attempts to access potentially non-existing array keys in the widget.

Created a helper function setParagraphsWidgetSettings it is both in ParagraphsTestBase and ParagraphsTestBaseTrait. In contrast to ParagraphsTestBase::setParagraphsWidgetMode, it can handle the new settings for experimental widget.

Adjusted the tests in ParagraphsExperimentalAdministrationTest, ParagraphsExperimentalInlineEntityFormTest and ParagraphsExperimentalWidgetButtonsTest to work with the new settings.

Added tests for the autocollapse functionality using the new BrowserTestBase base class.

Adjusted ParagraphsWidget::__construct to accommodate legacy settings.

1. +++ b/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
   @@ -74,6 +74,35 @@ class ParagraphsWidget extends WidgetBase {
      /**
   +   * @var array
   +   */
   +  protected $allSettingOptions;
   +
   

   missing docs.

2. +++ b/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
   @@ -163,6 +203,50 @@ class ParagraphsWidget extends WidgetBase {
   +   * Get select options for a plugin setting.
   +   *
   +   * This is done to allow settingsSummary to access option labels.
   +   * Not all plugin setting are available.
   

   GetS, but it's not really getting, Returns might be better?

   referencing another method needs to use class::method() should also use as much as possible of the 80 characters.

3. +++ b/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
   @@ -163,6 +203,50 @@ class ParagraphsWidget extends WidgetBase {
   +   * @param string $setting_name
   +   *   The name of the widget setting.
   +   * @return array|null
   +   *   An array of setting option usable as a value for a "#options" key.
   

   @param should list the support setting names.

   missing empty line above @return.

4. +++ b/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
   @@ -639,22 +702,28 @@ class ParagraphsWidget extends WidgetBase {
   +        if ($closed_mode_setting === 'preview') {
   +          // The closed paragraph is displayed as a rendered preview.
   +          $view_builder = $entity_type_manager->getViewBuilder('paragraph');
   +
   +          $element['subform'] = [];
   +          $element['behavior_plugins'] = [];
   +          $element['preview'] = $view_builder->view($paragraphs_entity, 'preview', $paragraphs_entity->language()->getId());
   +          $element['preview']['#access'] = $paragraphs_entity->access('view');
   

   part of those lines can be moved outside of the if now to avoid duplication.

   view access check here is interesting, wondering if that should be checked for summary as well, but being able to edit and not view seems like a pretty weird use case anyway?

5. +++ b/src/Plugin/Field/FieldWidget/ParagraphsWidget.php
   @@ -1226,6 +1297,15 @@ class ParagraphsWidget extends WidgetBase {
   +    // Close all other paragraphs, if autocollapse is on.
   +    if ($widget_state['real_item_count'] > 0 && $widget_state['autocollapse'] !== 'none') {
   +      foreach ($widget_state['paragraphs'] as $delta => $value) {
   +        if ($widget_state['paragraphs'][$delta]['mode'] === 'edit') {
   +          $widget_state['paragraphs'][$delta]['mode'] = 'closed';
   +        }
   +      }
   +    }
   +
   

   this snippet exists in 3, slightly different variations, can we define a helper method for it?

6. +++ b/src/Tests/Classic/ParagraphsTestBase.php
   @@ -203,4 +205,51 @@ abstract class ParagraphsTestBase extends WebTestBase {
   +   * @param string $content_entity_type
   +   *   (optional) Machine name of the content entity type (e.g., "node" for a
   +   *   content type, "paragraph" for a paragraphs type, etc.) that the bundle
   +   *   belongs to. Defaults to a content type.
   

   I think it's more common to refer to this just as $entity_type_id. And not sure that we need that extensive documentation on it, anoyne who uses this should know what an entity type is. Also the defaults is a bit confusing, Defaults to node is clearer than an indirect/implicit reference to content _type (which should be node_type in code).

   same for the one on the rait.

   Also, do we really need this on the base class, can't we use the trait if we have a method that needs it?

7. +++ b/src/Tests/Experimental/ParagraphsExperimentalAdministrationTest.php
   @@ -286,8 +290,8 @@ class ParagraphsExperimentalAdministrationTest extends ParagraphsExperimentalTes
        $this->drupalPostAjaxForm(NULL, array(), "field_paragraphs_settings_edit");
   -    // Assert the 'Preview' option is selected.
   -    $this->assertOptionSelected('edit-fields-field-paragraphs-settings-edit-form-settings-edit-mode', 'preview', 'Updated value correctly.');
   +    // Assert the 'Closed' option is selected.
   +    $this->assertOptionSelected('edit-fields-field-paragraphs-settings-edit-form-settings-edit-mode', 'closed', 'Updated value correctly.');
        // Restore the value to Open for next test.
   

   should also assert that the preview closed mode is selected in that case.

8. +++ b/src/Tests/Experimental/ParagraphsExperimentalAdministrationTest.php
   @@ -491,14 +498,20 @@ class ParagraphsExperimentalAdministrationTest extends ParagraphsExperimentalTes
        $node = $this->drupalGetNodeByTitle('choke test');
        // Attempt to edit the Paragraph.
   -    $this->drupalPostAjaxForm('node/' . $node->id() . '/edit', [], 'field_paragraphs_0_edit');
   +    $this->drupalGet('node/' . $node->id() . '/edit');
   +    // Since we have another validation error, the paragraph is by default in
   +    // the edit mode again.
   +    $this->assertFieldByName('field_paragraphs[0][subform][field_entity_reference][0][target_id]');
   +    $this->assertFieldByName('field_paragraphs[0][subform][field_entity_reference][1][target_id]');
        // Try to save with and invalid reference.
        $edit = ['field_paragraphs[0][subform][field_entity_reference][0][target_id]' => 'foo'];
   

   that looks like an unrelated behavior change?

9. +++ b/tests/src/Functional/ParagraphsExperimentalWidgetButtonsTest.php
   @@ -0,0 +1,253 @@
   +      'administer nodes',
   

   do we really need administer nodes for this this? The trickery with ParagraphsCoreVersionUiTestTrait is only needed in case the user has this permission, otherwise it is always "Save". The permission is only needed to control status, revision, author, .. of the node.

10. +++ b/tests/src/Functional/ParagraphsExperimentalWidgetButtonsTest.php
    @@ -0,0 +1,253 @@
    +  // @todo Move the rest of \Drupal\paragraphs\Tests\Experimental\ParagraphsExperimentalWidgetButtonsTest
    +  //   here.
    +
    

    strange position for a todo, should instead be on the class doc.

    What exactly is the other on testing that this doesn't cover yet? @todo could maybe be a bit more specific. And we should create a follow-up issue and reference it.

11. +++ b/tests/src/Functional/ParagraphsExperimentalWidgetButtonsTest.php
    @@ -0,0 +1,253 @@
    +    $option = $this->assertSession()->optionExists('fields[field_paragraphs][type]', 'paragraphs');;
    

    ;;

12. +++ b/tests/src/Functional/ParagraphsExperimentalWidgetButtonsTest.php
    @@ -0,0 +1,253 @@
    +    if ($mode === 'edit') {
    +      $this->assertSession()->buttonNotExists($button_prefix . '_edit');
    +      $this->assertSession()->buttonExists($button_prefix . '_collapse');
    +    }
    +    else if ($mode === 'closed') {
    +      $this->assertSession()->buttonExists($button_prefix . '_edit');
    +      $this->assertSession()->buttonNotExists($button_prefix . '_collapse');
    +    }
    

    seems like a cood case for a switch statement, would be easier to read.

@Berdir:

1.
That variable was unused. I removed it.

4.
Added a view access check to the summary as well.

8.
Kept the behavior change, as discussed.

10.
Deleted the @todo annotation for now.

I resolved the other points.

Fixed the tests and simplified ParagraphsWidget::autocollapse.

Re-roll.