Problem/Motivation

Paragraphs 8.x-1.x branch is currently failing due to recent Core changes on 8.4.x branch.

#2068063: Change "Save and keep un-/published" buttons to a "Published" checkbox and an included "Save" button

Proposed resolution

Go through the list of failing tests and update them accordingly.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 update_tests_with_the-2887759-9-interdiff.txt687 bytesmbovan
#9 update_tests_with_the-2887759-9.patch89.27 KBmbovan
#7 update_tests_with_the-2887759-7.patch88.88 KBmbovan
#2 update_tests_with_the-2887759-2.patch45.1 KBmbovan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mbovan created an issue. See original summary.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Active » Needs review
FileSize
update_tests_with_the-2887759-2.patch45.1 KB

First try to fix tests.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 2: update_tests_with_the-2887759-2.patch, failed testing. View results

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented 
+++ b/src/Tests/Experimental/ParagraphsExperimentalTranslationTest.php
@@ -98,7 +98,7 @@ class ParagraphsExperimentalTranslationTest extends ParagraphsExperimentalTestBa
-    $this->drupalPostForm(NULL, $edit, t('Save and keep published'));
+    $this->drupalPostForm(NULL, $edit, t('Save'));

@@ -186,7 +186,7 @@ class ParagraphsExperimentalTranslationTest extends ParagraphsExperimentalTestBa
-    $this->drupalPostForm(NULL, NULL, t('Save and keep published (this translation)'));
+    $this->drupalPostForm(NULL, NULL, t('Save (this translation)'));

@@ -442,7 +442,7 @@ class ParagraphsExperimentalTranslationTest extends ParagraphsExperimentalTestBa
-    $this->drupalPostForm(NULL, NULL, t('Save and keep published (this translation)'));
+    $this->drupalPostForm(NULL, NULL, t('Save (this translation)'));

Should we add something like $this->drupalPostFormSave($edit, $d8_4, $d8_3) where we pass in both strings and we internally do the core check?

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented

Please also trigger 8.3 tests after upload.

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
update_tests_with_the-2887759-7.patch88.88 KB

Add helper method for different form submissions depending on the core version.

Status: Needs review » Needs work

The last submitted patch, 7: update_tests_with_the-2887759-7.patch, failed testing. View results

mbovan’s picture

mbovan CreditAttribution: mbovan at MD Systems GmbH commented
Status: Needs work » Needs review
FileSize
update_tests_with_the-2887759-9.patch89.27 KB
update_tests_with_the-2887759-9-interdiff.txt687 bytes

Added missing trait import.

  • Primsi committed 7902ccc on 8.x-1.x authored by mbovan 
    Issue #2887759 by mbovan, miro_dietiker: Update tests with the recent...
Primsi’s picture

Primsi CreditAttribution: Primsi at MD Systems GmbH for MD Systems GmbH commented
Status: Needs review » Fixed

Committed, many thanks :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.