Problem/Motivation

There are assertions in ParagraphsPreviewTest::testParagraphsPreview() that had to be commented out because of the bug described in #2548713: Only one additional new value saved unlimited field and no non-field values are restored after preview.

Now that that issue is fixed, previewing new paragraphs should work.

Proposed resolution

Uncomment the relevant lines in ParagraphsPreviewTest.php. The section is marked with a @todo tag.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 uncomment_assertions_in-2836047-3.patch1.38 KBVladimirMarko
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

VladimirMarko created an issue. See original summary.

VladimirMarko’s picture

VladimirMarko CreditAttribution: VladimirMarko at MD Systems GmbH commented
Title: Uncomment assertion in ParagraphsPreviewTest now that the relevant bug in Core is fixed » Uncomment assertions in ParagraphsPreviewTest now that the relevant bug in Core is fixed
Issue summary: View changes
VladimirMarko’s picture

VladimirMarko CreditAttribution: VladimirMarko at MD Systems GmbH commented
Status: Active » Needs review
FileSize
uncomment_assertions_in-2836047-3.patch1.38 KB

Status: Needs review » Needs work

The last submitted patch, 3: uncomment_assertions_in-2836047-3.patch, failed testing.

VladimirMarko’s picture

VladimirMarko CreditAttribution: VladimirMarko at MD Systems GmbH commented
Issue summary: View changes
Related issues: +#2548713: Only one additional new value saved unlimited field and no non-field values are restored after preview
toncic’s picture

toncic CreditAttribution: toncic at MD Systems GmbH commented
Status: Needs work » Closed (duplicate)

#2836242: Fix ParagraphsAccessTest

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Closed (duplicate) » Needs review

No, this is not a duplicate.

VladimirMarko’s picture

VladimirMarko CreditAttribution: VladimirMarko at MD Systems GmbH commented

To explain:

This issue is about changing testParagraphsPreview().
#2836242: Fix ParagraphsAccessTest fixes a problem in testParagraphAccessCheck() so this issue is not a duplicate.

The only relation of this issue to testParagraphAccessCheck() is that my patch fails that test.
But that's not related to my patch - 8.x-1.x-dev also currently fails it, because Core changed.

#2836242: Fix ParagraphsAccessTest does not implement the changes described in this issue's Motivation.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Reviewed & tested by the community

should pass the re-test now.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Is it possible that this is committed also as part of some other issue?
I applied on HEAD^^ and after stashing and poping on 8.x-1.x nothing remained?
I think it happened with commit 872a315021e

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Related issues: +#2780363: Use ParagraphsTestBase wherever it makes sense

Connecting issue that resolved it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.