Our tests currently run mostly on PHP 5.6, but also do PHP 5.5, 5.4, 7,0, 7,2 and hhvm.

I'd like to propose the following:

  • Drop hhvm entirely. They moved on from PHP to Hack, see https://www.infoworld.com/article/3226489/forget-php-facebooks-hhvm-engi...
  • Drop PHP 5.5 and 5.4. They haven't worked right on Travis for a long time anyway, so this is just effectively codifying the current state of reality, and with less build failed messages getting sent out.
  • Making PHP 7.2 the default. This is the new "lowest" PHP, with PHP 7.3 and 7.4 being the cutting edge ones.
  • Adding PHP 7.1. It's just weird having 7.0 and 7.2, but not 7.1. :-)
CommentFileSizeAuthor
#3 panopoly-travis-php-3137664-2.patch761 bytesdsnopek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dsnopek created an issue. See original summary.

dsnopek’s picture

Status: Active » Needs review

Here's the patch!

I've got a build pending on Travis:

https://travis-ci.org/github/panopoly/panopoly/builds/688553750

Assuming this works, I'm going to commit it. If anyone objects, we can always add a PHP version back that was removed.

dsnopek’s picture

I forgot to upload the actual patch!

There's some failures, but I don't think they are due to this change. Assuming the PHP 7.1 build works when re-run, I think I'll merge this and address the failures in another ticket.

  • dsnopek committed d40f2f0 on 7.x-1.x
    Issue #3137664 by dsnopek: Modernize the set of PHP versions used in the...
dsnopek’s picture

Status: Needs review » Fixed

PHP 7.1 passed, so committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.