Got this Fatal error while editing a node and wanted to save it:
Call to undefined method InsertQuery_mysql::condition() in /Applications/MAMP/htdocs/drupal-7.0-beta/sites/mori.drupal7.dev/modules/layout/panels/panels_node/panels_node.module on line 305

Previewing works !!!
When reloading the page after the error the selected values have gone.

All modules & drupal are on newest dev-versions.
Panel-Dev-Version 7.x-3.x-dev (2010-Nov-06) is working !!!

The error came up while I tried to select a node-reference (cck module with just "node-relationship" enabled) from a select field.

Yesterday this worked, but I also updated field-group.

Comments

drupa11y’s picture

Priority: Major » Critical

Updates to latest dev versions and still get the error, now also previewing / saving a node:

Fatal error: Call to undefined method InsertQuery_mysql::condition() in /Applications/MAMP/htdocs/drupal-7.0-beta/sites/mori.drupal7.dev/modules/layout/panels/panels_node/panels_node.module on line 305

But there are no messages in the reports log to this.

drupa11y’s picture

The error does not come up when creating a new node, only after the try to edit it.

When creating new content it saves correctly with this warning:
Warning: implode(): Invalid arguments passed in form_error() (line 1487 of /Applications/MAMP/htdocs/drupal-7.0-beta/includes/form.inc).

And it only seems to occur when the content-type has a field of type "Term reference" in it.

merlinofchaos’s picture

Status: Active » Fixed
StatusFileSize
new1.07 KB

Committed this patch, it should fix it.

drupa11y’s picture

Status: Fixed » Active

Disabling "Panel nodes","Mini panels" and the "In-Place Editor" solves the problem.

Panels is 7.x-3.0-alpha1

Seems to be the "mini panels" module, when I enable it this warning comes up:
The plugin definition of panels_mini cannot locate schema panels_mini.

After this the error is present again.

Hope this helps !!!

drupa11y’s picture

the log messages after turning on mini-panels:

Type php
Date Tuesday, 9. November 2010 - 8:08
User admin
Location http://mori.drupal7.dev/admin/modules/list/confirm
Referrer http://mori.drupal7.dev/admin/modules
Message Notice: Undefined property: Media::$uri in Media->__construct() (line 284 of /Applications/MAMP/htdocs/drupal-7.0-beta/sites/mori.drupal7.dev/modules/media/media/media.types.inc).
Severity notice

Type file
Date Tuesday, 9. November 2010 - 8:08
User admin
Location http://mori.drupal7.dev/admin/modules/list/confirm
Referrer http://mori.drupal7.dev/admin/modules
Message The file permissions could not be set on public://js/gmap_markers.js.
Severity error

Type php
Date Tuesday, 9. November 2010 - 8:08
User admin
Location http://mori.drupal7.dev/admin/modules/list/confirm
Referrer http://mori.drupal7.dev/admin/modules
Message Notice: Undefined index: menu prefix in ctools_export_ui_plugin_base_path() (line 401 of /Applications/MAMP/htdocs/drupal-7.0-beta/sites/mori.drupal7.dev/modules/corefunctions/ctools/includes/export-ui.inc).
Severity notice

Type file
Date Tuesday, 9. November 2010 - 8:08
User admin
Location http://mori.drupal7.dev/admin/modules/list/confirm
Referrer http://mori.drupal7.dev/admin/modules
Message The file /Applications/MAMP/htdocs/drupal-7.0-beta/sites/mori.drupal7.dev/files/ctools/css was not deleted, because it does not exist.
Severity notice

Type file
Date Tuesday, 9. November 2010 - 8:08
User admin
Location http://mori.drupal7.dev/admin/modules/list/confirm
Referrer http://mori.drupal7.dev/admin/modules
Message The file permissions could not be set on public://js/gmap_markers.js.
Severity error

Type php
Date Tuesday, 9. November 2010 - 8:08
User admin
Location http://mori.drupal7.dev/admin/modules
Referrer http://mori.drupal7.dev/admin/modules
Message Notice: Undefined index: custom settings in field_view_mode_settings() (line 434 of /Applications/MAMP/htdocs/drupal-7.0-beta/modules/field/field.module).
Severity notice

drupa11y’s picture

Where should I save the patch or which file should be patched?

tried it in the "panels" and "panels_node"-folder.

When its placed in the panels folder I got this message:
mori-mbp-17:panels mori$ patch < 965286-insert-instead-of-update.patch
can't find file to patch at input line 21
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|? .git
|? 920266-panels-simple_cache-t.patch
|? 940002-fix-custom-style.patch
|? 941532-panel-nodes-really-broken.patch
|? 953484-classes-broken-on-panes.patch
|? 954323-mini-panels-failed-during-uninstall.patch
|? 958072-bad-node-access.patch
|? 965286-insert-instead-of-update.patch
|? ctools-358953-12.patch
|? panels-917614.patch
|? panels-932632.patch
|? panels.panels_update_6310.patch
|? panels_ipe_i18n.patch
|Index: panels_node/panels_node.module
|===================================================================
|RCS file: /cvs/drupal-contrib/contributions/modules/panels/panels_node/panels_node.module,v
|retrieving revision 1.11
|diff -u -p -r1.11 panels_node.module
|--- panels_node/panels_node.module 6 Nov 2010 19:35:25 -0000 1.11
|+++ panels_node/panels_node.module 9 Nov 2010 07:03:11 -0000
--------------------------
File to patch:

Sorry - don´t now what to do now?

drupa11y’s picture

ALL IS PERFECT - changed the query by hand !!!

THANK YOU VERY MUCH for this superfast fix !!!!!

drupa11y’s picture

Status: Active » Closed (fixed)
merlinofchaos’s picture

The proper way to apply this patch would be:

patch -p0 < 965286-insert-instead-of-update.patch 	

You'd do this from the root panels directory.

Mini panels was not involved.

avo_liao’s picture

Thanks for the patch. Applied it manually (hope correctly) and the issue was solved.

Couldn't apply the patch with the patch command though, the following error appeared:

patch -p0 < 965286-insert-instead-of-update.patch
patching file panels_node/panels_node.module
Hunk #1 FAILED at 307.
1 out of 1 hunk FAILED -- saving rejects to file panels_node/panels_node.module.rej

GarbageXAY1979’s picture

I get this same error when enable Panel nodes 7.x-3.0-alpha1 module. Disabling this module solves the problem. I downloaded the latest stable version of the panels zip file. Is this patch not yet in that release? I do not need the said module yet so it's easier to just keep it as is, but am wondering when the patch will be applied to stable release?

Cheers,
Alex

thesurfinganalyst’s picture

subscribe

GarbageXAY1979’s picture

Subscribe to what exactly? Mailinglist for this module?

paulgodard’s picture

I had the same issue and I tried to follow the procedure to patch the problem but the patch failed. BTW disabling the 3 sub-modules in panel worked temporary. Please help.

MacPro:Drupal-7 paul$ patch -p0 < 965286-insert-instead-of-update.patch
can't find file to patch at input line 21
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|? .git
|? 920266-panels-simple_cache-t.patch
|? 940002-fix-custom-style.patch
|? 941532-panel-nodes-really-broken.patch
|? 953484-classes-broken-on-panes.patch
|? 954323-mini-panels-failed-during-uninstall.patch
|? 958072-bad-node-access.patch
|? 965286-insert-instead-of-update.patch
|? ctools-358953-12.patch
|? panels-917614.patch
|? panels-932632.patch
|? panels.panels_update_6310.patch
|? panels_ipe_i18n.patch
|Index: panels_node/panels_node.module
|===================================================================
|RCS file: /cvs/drupal-contrib/contributions/modules/panels/panels_node/panels_node.module,v
|retrieving revision 1.11
|diff -u -p -r1.11 panels_node.module
|--- panels_node/panels_node.module 6 Nov 2010 19:35:25 -0000 1.11
|+++ panels_node/panels_node.module 9 Nov 2010 07:03:11 -0000
--------------------------

paulgodard’s picture

I could apply the patch to panel 7.x-3.0-alpha1 but now got a failed. I am very new to drupal... so please do not shout at me...

MacPro:panels paul$ patch -p0 < 965286-insert-instead-of-update.patch
patching file panels_node/panels_node.module
Hunk #1 FAILED at 307.
1 out of 1 hunk FAILED -- saving rejects to file panels_node/panels_node.module.rej

merlinofchaos’s picture

AT this stage you shouldn't need this patch. It was committed in November, and is in the alpha2 release.

  • Commit 5bfdb50 on 7.x-3.x, master, pipelines, 7.x-3.x-i18n, 8.x-3.x by merlinofchaos:
    #965286: Panel node update was trying to use db_insert() instead of...