If you have a parent Space with a banner image and banner position of "Above toolbar (stretched)", the same banner image will be used by child spaces.

However, if you use a banner position of "Next to Main menu", then child spaces won't inherit the banner image!

This is due to oa_toolbar pulling in the image itself rather than using the oa_appearance_get_space_banner() function from oa_appearance which understands inheritance.

I'll post a patch in a moment!

CommentFileSizeAuthor
#3 interdiff.txt706 bytesdsnopek
#3 oa_toolbar-banner-inheritance-2413869-3.patch2.32 KBdsnopek
#1 oa_toolbar-banner-inheritance-2413869-1.patch2.3 KBdsnopek

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Active » Needs review
Related issues: +#2413891: oa_appearance_get_space_banner() doesn't put $return['image']['attributes']['class'] in array
StatusFileSize
new oa_toolbar-banner-inheritance-2413869-1.patch2.3 KB

Patch is attached!

This patch depends on #2413891: oa_appearance_get_space_banner() doesn't put $return['image']['attributes']['class'] in array - without it, you'll get a PHP fatal error:

PHP Fatal error:  [] operator not supported for strings in /var/aegir/prj/bucketb_atrium/modules/panopoly/panopoly_images/panopoly_images.module on line 119
mpotter’s picture

mpotter commented
Status: Needs review » Needs work

When I apply this patch the default Open Atrium logo disappears from my pages. So still needs some work.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs work » Needs review
StatusFileSize
new oa_toolbar-banner-inheritance-2413869-3.patch2.32 KB
new interdiff.txt706 bytes

Ah, sorry about that! This new version of the patch should fix that. I've included an interdiff too, so you can see the change. :-)

hefox’s picture

hefox commented
Status: Needs review » Fixed

As mpotter just said on our company chat, the banner logic needs to be worked in general but this does fix that issue so comitting.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.