oa_appearance_get_space_banner() returns an associative array (let's call it $return) which includes $return['image'] which is meant to be an associative array that you can use like theme('image', $return['image']); or theme('image_style', $return['image']) (or, at least that was my intention - I originally wrote that function ;-)).

In any case, it get's it slight wrong having $return['image']['attributes']['class'] as a string rather than an array.

The fix is simple - I'll upload a patch in a moment.

Comments

dsnopek’s picture

Status: Active » Needs review
StatusFileSize
new501 bytes

Patch is attached!

mpotter’s picture

Status: Needs review » Fixed

From looking at the code, drupal_attributes does an (array) typecast so appears to accept both an array as well as a single string value.

However, for sake of better code, I have applied the patch. But you missed a similar case later in that same function where it was setting 'class' to a string value based on a conditional, so I updated that also.

Committed to 5e46b7f of oa_appearance.

dsnopek’s picture

Ah, good catch! Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.