After enabling and creating a new article, I ran the drush cron to send the notifications. I received these messages (edited for privacy):

in_array() expects parameter 2 to be array, null given notify.module:743                                     [warning]
exim: bad -f address "Your Sitename": missing or malformed local part (expected word or "<")
Error sending email (from webmaster@sitename.com to webmaster@sitename.com with reply-to not   [error]
set).
in_array() expects parameter 2 to be array, null given notify.module:743                                     [warning]
exim: bad -f address "Your Sitename": missing or malformed local part (expected word or "<")
Error sending email (from webmaster@sitename.com to youruser@yourplace.com with reply-to not set).  [error]
Cron run successful.                                                                                         [success]
Unable to send email. Contact the site administrator if the problem persists.                                [error]

I got this error for each of my users. There may be two issues here or they may be part of the same thing. It seems that the reply-to address is either not set at all or is set to the Site Name with an expected email address after it in <>

For example:
Site Name <site_email@site.com>

Regardless, the notification did not reach my users, even though the logging message (in /admin/reports/dblog) did say it was successfully sent:
User Your User (youruser@yourplace.com) notified successfully.

The same errors that appeared above appear in logging as well, but the exim messages did not.

CommentFileSizeAuthor
#5 reply_to_update-2952325-5.patch541 byteskferencz91

Comments

joverstreet001 created an issue. See original summary.

joverstreet001’s picture

Issue summary: View changes
joverstreet001’s picture

Issue summary: View changes
joverstreet001’s picture

I updated to the latest version and the site name issue seems to be resolved, but the emails still aren't being sent. The only errors I'm getting are:

Unable to send email. Contact the site administrator if the problem persists.

...when I'm choosing 'Send batch now' and the log shows the same error as described above:

Error sending email (from webmaster@sitename.com to youruser@yourplace.com with reply-to not set).

I've seen a couple of other modules with this error such as https://www.drupal.org/project/smtp/issues/2622678, where it may be that there's just an issue sending emails and this message is a side-effect.

Other things (like resetting passwords or activating a user) are sending emails without issue.

Any ideas on what's causing the reply-to not set issue?

kferencz91’s picture

StatusFileSize
new541 bytes

The quotation marks around the $messagefrom variable in notify.module seemed to be the issue for me. Once I removed them, notifications were sent. Patch attached (first contrib patch, so sorry if the naming convention or anything is off! Please advise if it needs updated!)

kferencz91’s picture

Status: Active » Needs review
joverstreet001’s picture

Thank you @kferencz91 for working on this! I got around this particular issue by loading the SMTP Authentication Support module (https://www.drupal.org/project/smtp), which allows me to explicitly define things like the From address.

I'll try to load up a test environment without it and test your patch when I have some extra time. This module seems like it would be in more demand, but it seems to need some developer attention.

Thanks again!

gisle’s picture

This module seems like it would be in more demand, but it seems to need some developer attention.

Unfortunately, nobody has signed up for the vacant position as maintainer of the Drupal 8 version of Notify.

I actively maintain the Drupal 7 version (and I have clients that are paying me for doing it). As for the Drupal 8 version, I have no sponsorship.

However, I will commit Drupal 8 patches created by the community to the repo, but only after the community have tested them and declared them to be RTBC.

joverstreet001’s picture

Gisle,

I really appreciate all of the work you've done on this project. I wish I was more of a developer and that I could help out, but I'm more on the devops side and would probably break more things than I fixed. Let me know if there are things I could do to test or troubleshoot this module or help out in some other way.

Thanks again!

vuil’s picture

Status: Needs review » Reviewed & tested by the community
vuil’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

  • ilchovuchkov committed e758061 on 8.x-1.x
    Issue #2952325 by ilchovuchkov, kferencz91: Email seems to be using site...
vuil’s picture

Status: Patch (to be ported) » Fixed

The patch has been committed! Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.