Custom add/remove link text should be translated

Good point -- We should translate the custom links.

Yeah, would be great to have these translatable.
I'm no php developer but here are some pointers on how to do this:
http://drupal.org/node/579722#comment-3114550

Part of the problem here is that variables are not supposed to be passed to the t() function which given that the add / remove from queue link strings here are undefined in the module code they are variable and thus not a candidate for use by t().

From API docs: http://api.drupal.org/api/function/t/6

"Because t() is designed for handling code-based strings, in almost all cases, the actual string and not a variable must be passed through t().

Extraction of translations is done based on the strings contained in t() calls. If a variable is passed through t(), the content of the variable cannot be extracted from the file for translation."

See more discussion on this subject here:

http://groups.drupal.org/node/15177

Hi everybody,

I find the solution to this problem.

On the nodequeue.module line 2278, you have to change :

$text = str_replace('%subqueue', $subqueue->title, $text);

by

$text = str_replace('%subqueue', t($subqueue->title), t($text));

So, you can add translation for your add/ remove link like :

Remove from the %subqueue listing ->Retirer du listing %subqueue
Add to the %subqueue listing : Ajouter au listing %subqueue

You can also add translation for your subqueue title

Here's the patch against 6.x-2.x-dev corresponding to comment #6.
My editor removes unnecessary spaces, these are in the patch as well.

Here's the patch against HEAD corresponding to comment #6.
My editor removes unnecessary spaces, these are in the patch as well.

Passing in t($text) as the 3rd (subject) seems like awkward use of str_replace().

Wouldn't correct use of t() really call for $title = t($title, array('%subqueue' => $subqueue->title)); ?

jaydub is correct in #5, we can't use t() for user defined strings. The solution here would be to use i18nstrings from the i18n module.

Nothing on this yet?

Any further testing needed?