When adding nodes to a taxonomy queue subqueue via the "Select title to add" autocomplete box, the results should be filtered by the same filters applicable for the subqueue. For example, if I have a vocabulary "category" (non multi-select) with the terms "products", "news", with a taxonomy queue linked to categories, when I go to add a node to the "products" subqueue it should not display nodes in the "news" subqueue.

CommentFileSizeAuthor
#7 nodequeue-taxonomy_smartqueue_filter_autocomplete-D7-293315-7.patch1.97 KBgnuget
#6 nodequeue-taxonomy_smartqueue_filter_autocomplete-D7-293315-6.patch1.7 KBgnuget
#4 293315-taxonomy_smartqueue_filter_autocomplete-D6.patch1.08 KBamateescu

Comments

franceslui’s picture

franceslui commented
Version: 5.x-2.x-dev » 6.x-2.0-rc3
Priority: Normal » Critical

I also agree with what DamienMcKenna said in the bug report. This serious bug is still in version 6.x-2.0-rc3. I hope it can be fixed very soon. Thank you.

ezra-g’s picture

ezra-g commented
Priority: Critical » Normal

I agree that this is an important bug that should be fixed, but I don't think it should be marked as critical. Perhaps we need to implement a new hook for auto completion so that smartqueues can provide this functionality as well.

franceslui’s picture

franceslui commented

Okay, it is not critical. I just wanted to emphasize that after users add a title, they expect that the title will be added. However, it is not the case and there are no errors or warnings if the new title cannot be added.

By the way, I suggest not using auto completion because users may have no idea what the first few characters are for the title they would like to add. Can we have drop down box which shows all the eligible titles that can be added?

amateescu’s picture

amateescu commented
Version: 6.x-2.0-rc3 » 6.x-2.x-dev
Status: Active » Patch (to be ported)
StatusFileSize
new 293315-taxonomy_smartqueue_filter_autocomplete-D6.patch1.08 KB

Fixing a three year old bug feels so good :)

Commited attached patch to 6.x.

amateescu’s picture

amateescu commented
Version: 6.x-2.x-dev » 7.x-2.x-dev

Wrong version..

gnuget’s picture

gnuget
Primary language Spanish
commented
Assigned: Unassigned » gnuget
Status: Patch (to be ported) » Needs review
StatusFileSize
new nodequeue-taxonomy_smartqueue_filter_autocomplete-D7-293315-6.patch1.7 KB

I adding a new patch for the 7.x-2.x-dev version.

gnuget’s picture

gnuget
Primary language Spanish
commented
StatusFileSize
new nodequeue-taxonomy_smartqueue_filter_autocomplete-D7-293315-7.patch1.97 KB

Oks,

Here a new and improved version of the previous patch.

For made this patch was needed edit the params passed to the hook_nodequeue_autocomplete(), because in the D7 version is not used the var $where and $where_args anymore.

So, i changed the params for instead to pass the $where and the $where_args into the function is now passed the $query object and the function who implement the api now returns a new $query object with the modifications.

  • fizk committed 7347cc1 on 7.x-2.x authored by gnuget 
    Issue #293315 by gnuget, amateescu: Subqueues do not filter results of...
fizk’s picture

fizk commented
Issue summary: View changes
Status: Needs review » Fixed

Committed #6, as it has less impact on existing code in the wild. Thanks!

fizk’s picture

fizk commented
Assigned: gnuget » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.