The introduction of #2483507 introduced a backwards-compatibility support issue with PHP 5.6, as the public keyword *is* required on constructors in PHP 5.6 (throws warning).

CommentFileSizeAuthor
#3 nodequeue-php-7-deprecated-warning-2638684-1-7-38.patch308 bytesemilflatz

Comments

emilflatz created an issue. See original summary.

jmary’s picture

jmary commented

patch ?

emilflatz’s picture

emilflatz commented
StatusFileSize
new nodequeue-php-7-deprecated-warning-2638684-1-7-38.patch308 bytes

It's already changed in the dev version although I was still getting warning without public keyword so I'm uploading the patch, my first drupal patch :).

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Closed (duplicate)

Yeah, seems like a duplicate of #2483507: Old-style php4 constructor throws deprecation notice on php7.

amanaplan’s picture

amanaplan commented
Title: PHP 7 warning » Public keyword is missing in constructor (throws warning)
Version: 7.x-2.0 » 7.x-2.x-dev
Category: Support request » Bug report
Issue summary: View changes
Status: Closed (duplicate) » Needs review

Reopening as this issue morphed into resolving a different issue introduced by #2483507.

amanaplan’s picture

amanaplan commented
Title: Public keyword is missing in constructor (throws warning) » Public keyword is missing in constructor (throws warning in PHP 5.6)
Issue summary: View changes
amanaplan’s picture

amanaplan commented
Issue summary: View changes
Related issues: +#2483507: Old-style php4 constructor throws deprecation notice on php7
amanaplan’s picture

amanaplan commented
Issue summary: View changes

  • fizk committed 2ae7835 on 7.x-2.x 
    Issue #2638684 by emilflatz: Public keyword is missing in constructor (...

fizk credited fizk.

fizk’s picture

fizk commented
Status: Needs review » Fixed

Thanks, committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.